Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check receipts should receive ticket IDs not PushTicket objects #56

Open
howieweiner opened this issue Mar 1, 2023 · 0 comments
Open

Comments

@howieweiner
Copy link

check_receipts and check_receipts_multiple expect to receive (a list of) PushTicket objects. Internally, the code then picks the ticket IDs from these objects to send to the getReceipts endpoint, as this is the only property of the class that is needed.

The docs recommend waiting 15 minutes before checking receipts, so it is unlikely that the PushTicket objects returned from the initial publish/publish_multiple task will reside in memory. In our case, we persist the ticket IDs to a database, and then process them with a scheduled task.

At the moment, we are having to create a list of PushTicket objects from our stored ticket IDs to then pass to the check_receipts method. Also, we cannot easily use the PushTicket class due the other required arguments, so we have implemented our own class purely to pass to this method.

Perhaps the method could receive either a lsit of PushTickets or a list of IDs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant