Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-updates] Use --profile in fingerprint:generate and runtimeversion:resolve to fetch related environment variables #2484

Closed
tfcornerstone opened this issue Aug 7, 2024 · 8 comments
Labels

Comments

@tfcornerstone
Copy link

Summary

Currently when using eas build, the local fingerprint uploaded to EAS is different from the output of expo-updates fingerprint:generate locally. The reason for this is the difference in env variables. No reason to maintain environment variables in different places when it can be read from the eas.json profile.

What platform(s) does this occur on?

Android, iOS

SDK Version

51.0.0

Environment

N/A

Minimal reproducible example

Try to build using EAS with environment variables and compare the fingerprint to normal expo-updates fingerprint

@Kudo
Copy link

Kudo commented Aug 8, 2024

hi there! could you share your build id? e.g. https://expo.dev/accounts/XXX/projects/XXX/builds/ee1bad22-a2c6-4c10-8ef2-281ea15980ee, the ee1bad22-a2c6-4c10-8ef2-281ea15980ee is the build id.

@tfcornerstone
Copy link
Author

@Kudo

2baa711b-ff01-4229-ab24-fdf4f7ebd9c8

I resolved the issue by setting the env variables of local to match the env variables in eas.json production profile.

Copy link

github-actions bot commented Sep 8, 2024

This issue is stale because it has been open for 30 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Sep 8, 2024
@mirague
Copy link

mirague commented Sep 10, 2024

This sounds like a pretty good addition, or is there a more "eas"-like way to achieve this?

@github-actions github-actions bot removed the stale label Sep 11, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Oct 11, 2024
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

@mirague
Copy link

mirague commented Oct 19, 2024

@Kudo any more insights or initiatives planned to align fingerprints between local and cloud builds?

@Kudo
Copy link

Kudo commented Oct 19, 2024

@mirague ideally local/cloud fingerprint should be aligned. would love to hear your use cases and figure out how fingerprint is inconsistent between local and cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants