Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Forwarded-Proto does not account for multiple values #8

Open
ChevronTango opened this issue Feb 20, 2023 · 0 comments
Open

X-Forwarded-Proto does not account for multiple values #8

ChevronTango opened this issue Feb 20, 2023 · 0 comments

Comments

@ChevronTango
Copy link

The specification for the X-Forwarded headers specifies that multiple comma separated values can be used when behind a series of proxies. The current server code does not account for this, and instead incorrectly assumes only a single value is present. This means that when it goes to build the full url it can produce something like http, http://myhost, myhost:8080

If possible this code should account for the multiple values.

In reality, when testing I found that pulling any information at all from the incoming request is prone to error and danger. It would be better to have the WS hostname defined as a server setting rather than pulling it from the host of the incoming request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant