-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express 5.0 - last push! #233
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!
Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are "direct deps" of |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I think that @chrisdel101 is actively working on it, maybe we can provide them more support. Aside of active development for sure you (@CBID2 @mertcanaltin) can work on:
I think that maybe @rxmarbles is working on it, based on slack comment |
Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@jonchurch do you think this needs to be added to the list above? expressjs/express#4851 EDIT: just to keep the records, this one is related as well I think expressjs/express#4852 |
I reviewed the remaining open things in |
This comment was marked as abuse.
This comment was marked as abuse.
@wesleytodd , would it be possible to detach features from the breaking changes needed for those features in order to speed up the release of The It's been 10 years. |
A number of things have been punted from the initial |
Ok, I just checked off an important one: "Look through the direct deps to see if they have things which need to land" I have gone through and commented on or resolved as many of the PR's/issues/discussions in the direct and transitives which seem to have some pending (breaking) changes to land. I added a few things on the list, but they are relatively small and should be simple enough to resolve. Which means, this is pretty much a complete final picture finally of what needs to be wrapped up to release. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
closes #2237 closes expressjs/discussions#233
Thank you @wesleytodd , @UlisesGascon , @ctcpip and others! |
We put a closes line in the commit, but looks like it didnt actually close this. So I can happily say this is closed as completed! |
I will relocate the pending things to 2 new issues (backlog for 5.x and Backlog for 6.0) :) |
Instead of #374 but non-breaking The express 5 beta 3 is fully operational and tested by community, but its release is delayed. The current issue is that it's also outdated comparing to v4.18.2, having nested dependencies of older versions. latest tracking issue: ``` expressjs/discussions#233 ``` previous one: ``` expressjs/express#5205 ``` Latest proposal: ``` expressjs/discussions#160 ``` Probably it will be ready in march 🤞🏽 (no, it's not) ``` expressjs/express#5111 (comment) ```
resolved via expressjs/express#2237 |
This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5.
Rules (WIP):
If you think that any reference is missing, please edit this comment (@expressjs/express-tc) or reply with a comment if you don't have the permissions.
Pending things (Express):
expires
andmaxAge
inres.clearCookie()
express#5792 (@jonchurch)Pending things (Dependencies):
@blakeembrey or@wesleytoddits a race)Pending things (Documentation):
Discussions pending:
New
Under Investigation
Decisions made:
Not in 5.x
Future Minors
The text was updated successfully, but these errors were encountered: