Skip to content

Weird error while deteching R verison #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andyquinterom opened this issue Feb 27, 2025 · 2 comments · May be fixed by #258
Open

Weird error while deteching R verison #257

andyquinterom opened this issue Feb 27, 2025 · 2 comments · May be fixed by #258

Comments

@andyquinterom
Copy link
Contributor

There is this weird bug (that I cannot reproduce outside of a very specific environment) when restoring a package from renv.

Basically, build.rs is unable to get the R version due to a NULL being printed before the version. There is no global R profile. The package install ok with remotes (even when renv is initialized).

Image

I think we could fix this by running this in a while loop or using an iteraton while a skip while.

Image
@andyquinterom andyquinterom linked a pull request Feb 27, 2025 that will close this issue
Open
@JosiahParry
Copy link

I'm wondering if semver would be better to use here as a build dependency. it could probably reduce the total amount of code required to parse the R version

@andyquinterom
Copy link
Contributor Author

I'm wondering if semver would be better to use here as a build dependency. it could probably reduce the total amount of code required to parse the R version

I wouldn't think so. semver has a lot of code to it. I think the current implementation is ok. Semver would not fix the handling of edge cases such as this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version finding on multiple lines andyquinterom/libR-sys
2 participants
@JosiahParry @andyquinterom