Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a variant class for OpenCL-xor-CUDA parameter pairs #26

Open
eyalroz opened this issue Jun 29, 2022 · 0 comments
Open

Use a variant class for OpenCL-xor-CUDA parameter pairs #26

eyalroz opened this issue Jun 29, 2022 · 0 comments
Assignees
@eyalroz
Labels
task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 29, 2022

There are multiple functions in kernel-runner.cpp which take both OpenCL-specific and CUDA-specific params - only one of which is non-empty / non-null. We could use a single variant class instead. This would be trivial in C++17 (std::variant), but we're stuck on C++14 for now.
@eyalroz eyalroz added the task label Jun 29, 2022
@eyalroz eyalroz self-assigned this Jun 29, 2022
@eyalroz eyalroz mentioned this issue Jul 5, 2022
Closed
@eyalroz eyalroz changed the title Use a variant class for OpenCL-or-CUDA params Use a variant class for OpenCL-xor-CUDA parameter pairs Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz