Fix a recursive find of directory argument being itself recursively browsed #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
On several of our "eZPlatform 2.5 + Legacy bridge" apps, with a purge_type "local" (no varnish / http), we sometimes stumbled on a 512Mo memory_limit reached when the cache is "old enough" (read "having lots of files") and the site owner edited some content in legacy back office. The error was always triggered on vendor/symfony/symfony/src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php:81
This PR fix the memory problem, which can be replaced by a "Maximum execution time of 30 seconds exceeded" (which will be harder to fix as it's only the time needed by the filesystem to remove its files).
Regards,
Marc
TODO:
$ composer test)$ composer fix-cs).