Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding forms in full view #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seeds
Copy link

@seeds seeds commented Jan 15, 2013

eZ Survey needs to have surveys added as a related object attribute to articles it want to be connected to. This causes surveys to only work with separate full views or causing the form to be placed on a specific place on a page. This patch will allow us to embed forms into articles (using the paperclip in OE) so that the form can be placed in any XML field in any object.

@nfrp
Copy link
Contributor

nfrp commented Jan 15, 2013

Thanks for the contribution, we will have a look into it promptly!

@@ -323,11 +338,13 @@ function processViewActions( $objectAttribute, &$survey, &$validation )
return false;
}

echo "d";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: This string is not translated, same with the one bellow.. ;)

@seeds
Copy link
Author

seeds commented Jan 15, 2013

Ops. Some debug info was still there. Thanks for pointing it out. Should be fixed now.

@nfrp
Copy link
Contributor

nfrp commented Jan 15, 2013

Good input.
It seems that this is a good functional addition: I believe we should prepare a few paragraphs/graphics to illustrate this in the eZ Survey documentation. Maybe @seeds you can bootstrap this content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants