Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping R&S #17

Open
ProofOfKeags opened this issue Jul 21, 2018 · 1 comment
Open

Swapping R&S #17

ProofOfKeags opened this issue Jul 21, 2018 · 1 comment

Comments

@ProofOfKeags
Copy link

, s -- swapping s & r, still don't know why

So I saw this comment and I think I figured out a root cause. When I was using the secp256k1 library maintained by haskoin here I discovered that the signature public key recovery only works if the r and s values are reversed...I would like to get this fixed but I haven't been able to get any correspondence from the project maintainers.

I believe that it is problematic that the library provides an incorrect implementation. What is the usual way to deal with things like this?

@martyall
Copy link

can you post an example to reproduce what you found?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants