Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fps counter #1745

Open
Meakk opened this issue Dec 3, 2024 · 3 comments
Open

Improve fps counter #1745

Meakk opened this issue Dec 3, 2024 · 3 comments
Assignees
Labels
help wanted Please help with this issue! source:libf3d type:enhancement New feature or request
Milestone

Comments

@Meakk
Copy link
Member

Meakk commented Dec 3, 2024

Describe the bug
The FPS counter is updated after each render, including when only the UI is updated which is not really useful because it reports >1000fps even for heavy models

It should be improved by:

  • Updating it only when the whole scene is rendered
  • Accumulate it over a few frames to give an average instead of showing the last frame performance only
@mwestphal mwestphal added this to F3D Dec 3, 2024
@mwestphal mwestphal added source:libf3d type:enhancement New feature or request help wanted Please help with this issue! labels Dec 3, 2024
@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@Meakk Meakk moved this to Discuss in F3D Dec 30, 2024
@GabrielNakamoto
Copy link

GabrielNakamoto commented Jan 5, 2025

If this is still open I would like to work on it. I just have one question: in what situations would the whole scene not be rendered?

@mwestphal
Copy link
Contributor

First of all is this still open?

Yes :)

If so I would like to work on it.

I've assigned it to you

I just have one question: in what situations would the whole scene not be rendered?

When we render only the UI, not the 3D scene

@GabrielNakamoto
Copy link

GabrielNakamoto commented Jan 5, 2025

PR #1886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please help with this issue! source:libf3d type:enhancement New feature or request
Projects
Status: Discuss
Development

No branches or pull requests

3 participants