Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I open a tab or just go on it less than 4 seconds it should be protected for 1hour instead of the usual 10minutes and should not count #126

Open
MerlinLaffitte opened this issue Oct 16, 2020 · 1 comment
Open

When I open a tab or just go on it less than 4 seconds it should be protected for 1hour instead of the usual 10minutes and should not count #126

MerlinLaffitte opened this issue Oct 16, 2020 · 1 comment
Labels
enhancement New feature or request P0
Milestone
V2

Comments

@MerlinLaffitte
Copy link
Collaborator

MerlinLaffitte commented Oct 16, 2020 •
edited
Loading

What

  • When I open a tab or just go on it less than 8 seconds it should be protected for 1hour instead of the usual 10minutes and should not count.

Steps

  • Add another protection to tabs if they have not been visited for at least 8seconds
  • Keep the previous one for visited tabs
  • Change the minimal activation time for const MIN_ACTIVE_DEBOUNCE = 1000 * 4; // minimum active reading on a tab
@MerlinLaffitte MerlinLaffitte added the enhancement New feature or request label Oct 16, 2020
@MerlinLaffitte MerlinLaffitte added this to the V2 milestone Oct 16, 2020
@MerlinLaffitte MerlinLaffitte changed the title When I open a tab or just go on it less than 8 seconds it should be protected for 1hour instead of the usual 10minutes and should not count When I open a tab or just go on it less than 4 seconds it should be protected for 1hour instead of the usual 10minutes and should not count Oct 21, 2020
@MerlinLaffitte
Copy link
Collaborator Author

Maybe with the exception of newTab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P0
Projects
None yet
Milestone
V2
Development

No branches or pull requests
1 participant
@MerlinLaffitte