From 2cf62ed955aa057f40ae3891d9b9e5526e2b60bd Mon Sep 17 00:00:00 2001
From: fabcor <fabien.coronis@maxiv.lu.se>
Date: Tue, 6 Feb 2024 17:19:48 +0100
Subject: [PATCH] Clean `conda-environment-dev.yml`

Fix the pinned version for `python-ldap`.

Add some explanatory comments.

Remove `pip` since it is already a dependency of `python`.

Remove `openldap` since it is already a dependency of `python-ldap`.
---
 conda-environment-dev.yml | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/conda-environment-dev.yml b/conda-environment-dev.yml
index df5014992a..05362a63c2 100644
--- a/conda-environment-dev.yml
+++ b/conda-environment-dev.yml
@@ -2,10 +2,21 @@ name: mxcubecore
 channels:
   - conda-forge
 dependencies:
+
+  ### Runtime dependencies
+
   - python >=3.8,<3.11
-  # Run-time
-  - openldap
-  - python-ldap=3.4.0
-  # Dev
-  - pip
+
+  # We install `python-ldap` from conda because it is "hard" to install.
+  # On PyPI it is not available as *wheel*, only as *sdist* which requires to be built
+  # with compilation steps that require a compiler and some header files.
+  # Installing with conda is much "easier".
+  #
+  # IMPORTANT:
+  # Always make sure that `python-ldap` here is pinned to the same version
+  # as in the Poetry lockfile `poetry.lock` (not the other way around).
+  - python-ldap=3.4.3
+
+  ### Development dependencies
+
   - poetry