From 6d0bc36fa8cca739a27a1f8b45943da79cf18bec Mon Sep 17 00:00:00 2001 From: Bastien Gatellier Date: Mon, 16 Oct 2023 20:51:56 +0200 Subject: [PATCH] ci: enable ecoCode eslint plugin (#199) * chore: add the eslint plugin * chore: add the eslint configuration --- ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ ...nable-ecocode-eslint_2023-10-11-20-50.json | 10 +++++ common/config/rush/pnpm-lock.yaml | 39 +++++++++++++++++++ modules/api/.eslintrc.yaml | 1 + modules/api/package.json | 1 + modules/cli/.eslintrc.yaml | 1 + modules/cli/package.json | 1 + modules/common/.eslintrc.yaml | 1 + modules/common/package.json | 1 + modules/greenit/.eslintrc.yaml | 1 + modules/greenit/package.json | 1 + modules/lighthouse/.eslintrc.yaml | 1 + modules/lighthouse/package.json | 1 + modules/mysql/.eslintrc.yaml | 1 + modules/mysql/package.json | 1 + modules/observatory/.eslintrc.yaml | 1 + modules/observatory/package.json | 1 + modules/slack/.eslintrc.yaml | 1 + modules/slack/package.json | 1 + modules/ssllabs-server/.eslintrc.yaml | 1 + modules/ssllabs-server/package.json | 1 + modules/tpl/.eslintrc.yaml | 1 + modules/tpl/package.json | 1 + 30 files changed, 149 insertions(+) create mode 100644 common/changes/@fabernovel/heart-api/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-cli/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-common/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-greenit/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-lighthouse/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-mysql/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-observatory/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-slack/chore-enable-ecocode-eslint_2023-10-11-20-50.json create mode 100644 common/changes/@fabernovel/heart-ssllabs-server/chore-enable-ecocode-eslint_2023-10-11-20-50.json diff --git a/common/changes/@fabernovel/heart-api/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-api/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..d7244e4c --- /dev/null +++ b/common/changes/@fabernovel/heart-api/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-api", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-api" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-cli/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-cli/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..9c375649 --- /dev/null +++ b/common/changes/@fabernovel/heart-cli/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-cli", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-cli" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-common/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-common/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..00109bfa --- /dev/null +++ b/common/changes/@fabernovel/heart-common/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-common", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-common" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-greenit/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-greenit/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..cf872683 --- /dev/null +++ b/common/changes/@fabernovel/heart-greenit/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-greenit", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-greenit" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-lighthouse/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-lighthouse/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..1dc7a5b4 --- /dev/null +++ b/common/changes/@fabernovel/heart-lighthouse/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-lighthouse", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-lighthouse" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-mysql/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-mysql/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..98dffbfc --- /dev/null +++ b/common/changes/@fabernovel/heart-mysql/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-mysql", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-mysql" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-observatory/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-observatory/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..efb3f0bd --- /dev/null +++ b/common/changes/@fabernovel/heart-observatory/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-observatory", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-observatory" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-slack/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-slack/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..6e10673e --- /dev/null +++ b/common/changes/@fabernovel/heart-slack/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-slack", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-slack" +} \ No newline at end of file diff --git a/common/changes/@fabernovel/heart-ssllabs-server/chore-enable-ecocode-eslint_2023-10-11-20-50.json b/common/changes/@fabernovel/heart-ssllabs-server/chore-enable-ecocode-eslint_2023-10-11-20-50.json new file mode 100644 index 00000000..49356fd5 --- /dev/null +++ b/common/changes/@fabernovel/heart-ssllabs-server/chore-enable-ecocode-eslint_2023-10-11-20-50.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@fabernovel/heart-ssllabs-server", + "comment": "", + "type": "none" + } + ], + "packageName": "@fabernovel/heart-ssllabs-server" +} \ No newline at end of file diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index a00da9ac..d857a74c 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -26,6 +26,9 @@ importers: specifier: ^4.23.2 version: 4.23.2 devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -84,6 +87,9 @@ importers: specifier: ^7.0.1 version: 7.0.1 devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@fastify/cors': specifier: ^8.4.0 version: 8.4.0 @@ -145,6 +151,9 @@ importers: specifier: ^10.2.3 version: 10.2.3 devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@fastify/cors': specifier: ^8.4.0 version: 8.4.0 @@ -206,6 +215,9 @@ importers: specifier: ^5.0.5 version: 5.0.5 devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -246,6 +258,9 @@ importers: specifier: ^21.2.1 version: 21.2.1(typescript@5.2.2) devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -292,6 +307,9 @@ importers: specifier: ^5.8.7 version: 5.8.7(@mikro-orm/core@5.8.7)(@mikro-orm/migrations@5.8.7) devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -335,6 +353,9 @@ importers: specifier: workspace:^4.0.0 version: link:../common devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -375,6 +396,9 @@ importers: specifier: ^6.9.0 version: 6.9.0 devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -412,6 +436,9 @@ importers: specifier: workspace:^4.0.0 version: link:../common devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -449,6 +476,9 @@ importers: specifier: workspace:^4.0.0 version: link:../common devDependencies: + '@ecocode/eslint-plugin': + specifier: ^0.2.0 + version: 0.2.0(eslint@8.51.0) '@jest/globals': specifier: ^29.7.0 version: 29.7.0 @@ -860,6 +890,15 @@ packages: '@jridgewell/trace-mapping': 0.3.9 dev: true + /@ecocode/eslint-plugin@0.2.0(eslint@8.51.0): + resolution: {integrity: sha512-21ejxs21aOxJGV3dE4SPXqibXszwB6ii/pqmjpxmKNtaUAb+whqYmNqP20M7e5JdACiN3Bh+zN4OsE+HgYRS4g==} + engines: {node: ^14.17.0 || ^16.0.0 || >= 18.0.0} + peerDependencies: + eslint: '>=7' + dependencies: + eslint: 8.51.0 + dev: true + /@eslint-community/eslint-utils@4.4.0(eslint@8.51.0): resolution: {integrity: sha512-1/sA4dwrzBAyeUoQ6oxahHKmrZvsnLCg4RfxW3ZFGGmQkSNQPFNLV9CUEFQP1x9EYXHTo5p6xdhZM1Ne9p/AfA==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} diff --git a/modules/api/.eslintrc.yaml b/modules/api/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/api/.eslintrc.yaml +++ b/modules/api/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/api/package.json b/modules/api/package.json index f41f933d..b2800047 100644 --- a/modules/api/package.json +++ b/modules/api/package.json @@ -41,6 +41,7 @@ "fastify": "^4.23.2" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/express": "^4.17.18", "@types/jest": "^29.5.5", diff --git a/modules/cli/.eslintrc.yaml b/modules/cli/.eslintrc.yaml index a4f59c96..26c7ff40 100644 --- a/modules/cli/.eslintrc.yaml +++ b/modules/cli/.eslintrc.yaml @@ -11,3 +11,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/cli/package.json b/modules/cli/package.json index 3db643e6..2012d999 100644 --- a/modules/cli/package.json +++ b/modules/cli/package.json @@ -45,6 +45,7 @@ "ora": "^7.0.1" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@fastify/cors": "^8.4.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", diff --git a/modules/common/.eslintrc.yaml b/modules/common/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/common/.eslintrc.yaml +++ b/modules/common/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/common/package.json b/modules/common/package.json index e56fc315..7b134a96 100644 --- a/modules/common/package.json +++ b/modules/common/package.json @@ -40,6 +40,7 @@ "pino-pretty": "^10.2.3" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@fastify/cors": "^8.4.0", "@jest/globals": "^29.7.0", "@types/har-format": "^1.2.13", diff --git a/modules/greenit/.eslintrc.yaml b/modules/greenit/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/greenit/.eslintrc.yaml +++ b/modules/greenit/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/greenit/package.json b/modules/greenit/package.json index a8da9af3..2d6ebaa3 100644 --- a/modules/greenit/package.json +++ b/modules/greenit/package.json @@ -47,6 +47,7 @@ "rimraf": "^5.0.5" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4", diff --git a/modules/lighthouse/.eslintrc.yaml b/modules/lighthouse/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/lighthouse/.eslintrc.yaml +++ b/modules/lighthouse/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/lighthouse/package.json b/modules/lighthouse/package.json index 42a68aa5..abb80a0c 100644 --- a/modules/lighthouse/package.json +++ b/modules/lighthouse/package.json @@ -40,6 +40,7 @@ "puppeteer": "^21.2.1" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4", diff --git a/modules/mysql/.eslintrc.yaml b/modules/mysql/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/mysql/.eslintrc.yaml +++ b/modules/mysql/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/mysql/package.json b/modules/mysql/package.json index c5bbe240..83f20f2b 100644 --- a/modules/mysql/package.json +++ b/modules/mysql/package.json @@ -40,6 +40,7 @@ "@mikro-orm/mysql": "^5.8.7" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@mikro-orm/cli": "^5.8.7", "@types/jest": "^29.5.5", diff --git a/modules/observatory/.eslintrc.yaml b/modules/observatory/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/observatory/.eslintrc.yaml +++ b/modules/observatory/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/observatory/package.json b/modules/observatory/package.json index d5856829..2f97d248 100644 --- a/modules/observatory/package.json +++ b/modules/observatory/package.json @@ -37,6 +37,7 @@ "@fabernovel/heart-common": "workspace:^4.0.0" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4", diff --git a/modules/slack/.eslintrc.yaml b/modules/slack/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/slack/.eslintrc.yaml +++ b/modules/slack/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/slack/package.json b/modules/slack/package.json index bc19ccc0..e96e37bc 100644 --- a/modules/slack/package.json +++ b/modules/slack/package.json @@ -38,6 +38,7 @@ "@slack/web-api": "^6.9.0" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4", diff --git a/modules/ssllabs-server/.eslintrc.yaml b/modules/ssllabs-server/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/ssllabs-server/.eslintrc.yaml +++ b/modules/ssllabs-server/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/ssllabs-server/package.json b/modules/ssllabs-server/package.json index 33e07466..ab73ae5c 100644 --- a/modules/ssllabs-server/package.json +++ b/modules/ssllabs-server/package.json @@ -37,6 +37,7 @@ "@fabernovel/heart-common": "workspace:^4.0.0" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4", diff --git a/modules/tpl/.eslintrc.yaml b/modules/tpl/.eslintrc.yaml index bfb1a637..6615ef24 100644 --- a/modules/tpl/.eslintrc.yaml +++ b/modules/tpl/.eslintrc.yaml @@ -9,3 +9,4 @@ extends: - "eslint:recommended" - "plugin:@typescript-eslint/strict-type-checked" - "plugin:@typescript-eslint/stylistic-type-checked" + - "plugin:@ecocode/recommended" diff --git a/modules/tpl/package.json b/modules/tpl/package.json index 563491f2..430301d1 100644 --- a/modules/tpl/package.json +++ b/modules/tpl/package.json @@ -35,6 +35,7 @@ "@fabernovel/heart-common": "workspace:^4.0.0" }, "devDependencies": { + "@ecocode/eslint-plugin": "^0.2.0", "@jest/globals": "^29.7.0", "@types/jest": "^29.5.5", "@types/node": "^18.18.4",