Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artefacts on certain objects #5

Open
deltabeard opened this issue Nov 5, 2022 · 15 comments
Open

Artefacts on certain objects #5

deltabeard opened this issue Nov 5, 2022 · 15 comments
Assignees
Labels
bug Something isn't working

Comments

@deltabeard
Copy link

deltabeard commented Nov 5, 2022

Hello. Great work on the project.

I was playing this on my Android phone in Firefox and noticed that there were some artefacts on some of the background objects once reaching the second ladder. See the screenshot below.

Screenshot_20221105-000712_Firefox

Thanks.

@fabioarnold fabioarnold added the bug Something isn't working label Nov 5, 2022
@fabioarnold fabioarnold self-assigned this Nov 5, 2022
@fabioarnold
Copy link
Owner

Thanks!

These look like floating point precision issues. Some tiles look like their coordinates are off by one. This will be very hard for me to reproduce. Sadly, I don't own an Android device. I tried setting all shaders to precision lowp float; without success.

Can you tell me what device this is? Also, have you tried the game using Chrome on your device?

@fabioarnold
Copy link
Owner

I added a bias to the tilemap shader in #6 and deployed this change to https://zeroman.space. Can you please try again? And don't forget to clear your cache.

@deltabeard
Copy link
Author

deltabeard commented Nov 5, 2022

This was on Firefox 106.1.0; Android 12; Samsung SM-G781B.

I have also tested this on Bromite (a Chromium fork) and I get the same problems.
Bug appears in Bromite

During my tests I suddenly got this error in Firefox and Edge on Windows 10, so I'm unable to continue testing for the time being.
image

Edit: Ah. I must have been testing whilst you were making changes. I'll test again.

@deltabeard
Copy link
Author

This new change has significantly improved the issue but there are still some tiny artefacts left on both Firefox and Bromite on Android:
Firefox
Bromite

@fabioarnold
Copy link
Owner

Ok, I increased the bias. Can you please try again?

@deltabeard
Copy link
Author

The latest change hasn't made any difference.

@fabioarnold
Copy link
Owner

One last try: I resized the tileset to a power of two.

@deltabeard
Copy link
Author

I can't test this because I can't get passed the start screen using the onscreen controls.
Screenshot_20221106-122714_Bromite

@fabioarnold
Copy link
Owner

Ah, sorry. I just deployed a version that handles touch on the title screen.

@deltabeard
Copy link
Author

The latest changes haven't a made a difference either.

Screenshot_20221106-124257_Bromite

It seems that the number of artefacts are very few.

@fabioarnold
Copy link
Owner

Thanks for testing. I probably need access to real hardware to fully resolve this issue. :(

@silversquirl
Copy link

fwiw, works fine in Firefox on my Pixel 4A. Perhaps it's an issue with lower screen resolutions?

@deltabeard
Copy link
Author

fwiw, works fine in Firefox on my Pixel 4A. Perhaps it's an issue with lower screen resolutions?

Thanks for testing. I think we can say that it isn't a browser or platform issue then.

The Pixel 4A is 1080x2340 whereas my phone is 1440x3200. So maybe it's a problem with higher resolutions?

@silversquirl
Copy link

Oops! My bad, should've checked the resolutions first

Could also be a hardware-specific thing, though they seem to have similar-ish GPUs (Adreno 618 on mine vs Adreno 650 on yours)

@deltabeard
Copy link
Author

Could also be a hardware-specific thing, though they seem to have similar-ish GPUs (Adreno 618 on mine vs Adreno 650 on yours)

What is the output of https://webglreport.com/?v=2 on your phone? I wonder if there is a difference to my results:
WebGL report for S20 5G FE

From the zeroman source code, it seems that WebGL 2 is used if it's available, so I wonder if there's something different with the specs of WebGL 2 on our phones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants