Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of non-existant generic parameters (redone) #80

Conversation

jwosty
Copy link
Contributor

@jwosty jwosty commented Sep 29, 2021

New attempt at #79, except replacing 'Out with unit instead of obj as per code review.

…L generation due to a bug in the F# compiler
@alfonsogarciacaro
Copy link
Member

Thanks!

@alfonsogarciacaro alfonsogarciacaro merged commit 07f9503 into fable-compiler:master Sep 29, 2021
@jwosty
Copy link
Contributor Author

jwosty commented Sep 29, 2021

@alfonsogarciacaro do you have any way to test this? I have not tested it.

@MangelMaxime
Copy link
Member

@jwosty The Fable.Browser API doesn't have any tests in it. So for now, we test it manually directly in our own projects directly 🙈 or via Fable REPL to see if its compile and works.

@alfonsogarciacaro
Copy link
Member

image

@alfonsogarciacaro
Copy link
Member

I've recently been using Web Test Runner. It makes it really easy to run tests against a headless Chrome and it works with Github Actions too. We could use it to set up some tests but it's a HUGE amount of work to properly test all the bindings, not sure if there are some tests from Typescript that we can try to translate automatically.

@MangelMaxime
Copy link
Member

@alfonsogarciacaro I think we can do it small bit by small bit.

Would you be able to set up the Web Test Runner with the Github action?

I am planning to fix #47 since a long time and would need a CI setup for that. If you are happy with Web Test Runner I would be happy to use it instead of Mocha here.

@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Sep 30, 2021
@jwosty jwosty deleted the fix/invalid-il-generation-take-2 branch May 13, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants