Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Revisit boosters marked with runsOn:none #330

Open
gastaldi opened this issue Mar 29, 2019 · 8 comments
Open

Revisit boosters marked with runsOn:none #330

gastaldi opened this issue Mar 29, 2019 · 8 comments

Comments

@gastaldi
Copy link
Contributor

Some boosters are marked to be runsOn: none, when in fact they work with Launcher (we tested the Vert.x SSO [1] and it works)

[1] - https://github.com/fabric8-launcher/launcher-booster-catalog/blob/master/vert.x/community/rest-http-secured/booster.yaml#L4

@gastaldi
Copy link
Contributor Author

@fabric8-launcher/runtime-fuse @fabric8-launcher/runtime-golang @fabric8-launcher/runtime-node-js @fabric8-launcher/runtime-spring-boot @fabric8-launcher/runtime-thorntail

@geoand
Copy link
Contributor

geoand commented Mar 29, 2019

What is the idea behind runsOn: none? Sorry, I have never seen that before

@gastaldi
Copy link
Contributor Author

@geoand
Copy link
Contributor

geoand commented Mar 29, 2019

So just looking at the booster I don't see why its runsOn value would be any different than what crud uses.
I see that is works in our CI environment (CircleCI that uses oc cluster up) just fine.

@gastaldi
Copy link
Contributor Author

@geoand that makes sense. As a side note, the value for CRUD needs to be revisited: #324

TLDR; the starter clusters had a small quota and now they are bigger

@geoand
Copy link
Contributor

geoand commented Mar 29, 2019

👍 I always had a terrible time with any hosted openshift cluster, so I doubt I'll be able to test it

@Ladicek
Copy link
Contributor

Ladicek commented Mar 29, 2019

Requires creating the .openshiftio stuff, but other than that, I don't see why not.

@quintesse
Copy link
Contributor

Btw, except for boosters that can really run nowhere without manual intervention (like for example the ISTIO boosters) we should always prefer "local" over "none". With "local" you will at least be able to deploy them to your local minishift or whatever you have running locally. Good for testing / demoing purposes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants