Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

the generated applications probably shouldn't contain the entirety of the booster's GitHub repo #51

Open
Ladicek opened this issue Apr 26, 2017 · 5 comments

Comments

@Ladicek
Copy link

Ladicek commented Apr 26, 2017

I'm thinking mainly of the .openshiftio directory, but maybe there's more.

@gastaldi
Copy link
Collaborator

You mean as a ZIP or deployed in Openshift? It should be removed when you choose to download as a ZIP

@Ladicek
Copy link
Author

Ladicek commented Apr 26, 2017

Let me check the .zip, but I'm seeing the .openshiftio directory in my GitHub repo.

... which doesn't go through the backend, so this is the wrong issue tracker, right? :-)

@gastaldi
Copy link
Collaborator

I believe that folder is needed to run the pipelines in Jenkins? Anyway, the backend is responsible to removing the .openshiftio dir, so if we should do that for the Open in Openshift button, this is the correct issue tracker :)

@Ladicek
Copy link
Author

Ladicek commented Apr 26, 2017

The Jenkinsfile is needed for the pipeline, but that's not in the .openshiftio directory. That only has the booster.yaml file.

Actually I was thinking about using the .openshiftio directory to store a Jenkinsfile for our own CI (which might be different from the top-level Jenkinsfile), that's why I had the idea that the .openshiftio directory should be removed.

vpavlin pushed a commit to vpavlin/launchpad-backend that referenced this issue Oct 12, 2017
…5b333e-b5c0-4920-8cd2-0657097e4015

PR merged! Thanks!
@Ladicek
Copy link
Author

Ladicek commented Nov 13, 2017

If you ever get to removing .openshiftio from generated Git repos / .zip archives, please make a noise. When migrating boosters tests to Arquillian Cube, we made some tests use the .openshiftio pieces (e.g. to deploy a DB in the CRUD booster). This will have to be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants