Convert namespace from aspect to argument in service layer

[pmuir]

Right now the namespace is injected and stored in both the stores and the services, which makes them very hard to reuse as composable services.

This happens via the NamespacedResourceService and NamespacedResourceStore.

Instead of injecting the namespace into a parent class, it would be better if operations like loadAll took an argument of namespace: Observable allowing the consumer to explicitly choose the namespace.

Relates to:

1. Remove store layer #146 - this is a longer term task to remove the store layer entirely
2. services should not call stores #147 - this issue (Convert namespace from aspect to argument in service layer #143) really a subtask (the most pressing) of services should not call stores #147.

[jstrachan]

relates to #146 (comment) - I wonder if we can use DI to inject the namespace from the route; using route specific injections? This would avoid the need to use Observable<Params> to watch for namespace changes?

[jstrachan]

also if we injected the namespace using the router; we could then look at adding more caching between related pages in the same namespace maybe?

[pmuir]

I just want to be able to call the service layer, passing in the namespace to look at.

[jstrachan]

yeah - we can maybe just put the ActiveRoute thingy on the observer producer objects and keep the services super simple?

[pmuir]

I think if the observer producers only extracted the namespace from the activeroute and then called in to the service layer, that would work well.

There is currently some useful functionality in the observer producer (aka store) layer (e.g. attaching a watcher, the loading stuff) that should move up in to the service layer - IOW the observer producer layer is simply a really thin facade that sets the right namespace.

WDYT?

[jstrachan]

yeah - sounds fine to me. Plus folks could compose the observable producers maybe with a different Observable<string> for the current namespace to the ActiveRoute params thingy (e.g. if it wanted to use a different namespace to the one from the route)