Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-time labels to generated docker image and allow to add custom ones #91

Open
mguillem opened this issue Oct 9, 2017 · 0 comments

Comments

@mguillem
Copy link

mguillem commented Oct 9, 2017

Currently my image built with the fabric8 maven plugin have labels like these ones even if the image has been build a few hours ago:

    build-date=20170605 
    io.fabric8.s2i.version.jolokia=1.3.6 
    io.fabric8.s2i.version.maven=3.3.3 
    io.k8s.description=Platform for building and running plain Java applications (fat-jar and flat classpath) 
    io.k8s.display-name=Java Applications 
    io.openshift.build.image=fabric8/s2i-java:2.0 
    io.openshift.build.name=svc-survey-s2i-1 
    io.openshift.build.namespace=it 
    io.openshift.build.source-location=/tmp/s2i-build511047928/upload/src 
    io.openshift.s2i.destination=/tmp 
    io.openshift.s2i.scripts-url=image:///usr/local/s2i 
    io.openshift.tags=builder,java 
    license=GPLv2 
    org.jboss.deployments-dir=/deployments 
    vendor=CentOS 

All these labels are not so interesting.

It would be great if the s2i-java builder could add labels to the generated docker image like those added to a generated deployment config (for instance fabric8.io/git-commit ) as well as custom ones.

According to this doc, it seems that this can be done by generating a /tmp/.s2i/image_metadata.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant