Keep BuildConfig configuration

[zonArt]

If wanting to update buildConfig with existing one
it could be good to keep the spec defined in it otherwise it
is the same than the recreate option
May fix #1054 and #1070

[hrishin]

@nicolaferraro could you please? :)

[FlorianBois]

While reviewing the commit, please check if my comment on the issue, if the fix really makes sens : #1070 (comment)

[zonArt]

I've maybe misunderstood the plugin's philosophy and if this is the case I'm sorry. But if not is it possible to help me finding a way to customize BuildConfigs and ImageStreams within f-m-p ?
Thanks

[zonArt]

Any news on this one ?

[rhuss]

Don't think this PR works as expected.

[rhuss]

I'm really not sure why this should fix something, as this is a no-op after all: You are re-setting the same strategy and output as it was there already. The whole idea of this method is to change the strategy (docker or binary s2i build) and the output stream if changed.

@zonArt could you please elaborate what are you trying to achieve ?

[rohanKanojia]

@rhuss : I read the related issue filed by @zonArt , I think he wants to have his pushSecrets kept in BuildConfig to push/pull from some private registry, maybe that's why he is setting same strategy and output itself.

Agreed that this doesn't align with plugin's flow at all. But is there some way to configure plugin to include these pushSecrets into BuildConfig?

[zonArt]

@rohanKanojia You got it totally right, being able to keep the configuration of the buildconfig and imagestream was the needed behavior thus this PR which was maybe not intended to be merged as is but more a way to request support on how to customize those objects or to find a way to keep provided ones (maybe with a flag)

[FlorianBois]

Here another proposal, to add pushSecret and pullSecret to the builld config.

master...ElcaIT:Feature/ThirdPartyRepositoryWithSecret

However, this probably need some rework :

• The build time out of the client has been increased, because the default is to low, a proper PR with configurable timeout should also be welcome
• this line withNewSpec().withDockerImageRepository(imageConfiguration.getRegistry()+"/"+imageName.getNameWithoutTag())
  on OpenshiftBuildService is highly to be wrongly coded, I took the registry from the imageConfiguration, but it is possible that it should come from an additional configuration or reuse another one (currently, there is many ways to tell the plugin there is a repository), taking the imageName without the image tag looks also more like a workaround than a real solution.

[rhuss]

@zonArt @FlorianBois Let me try to somerise the issue you are trying to solve. It's all about being able to configure pull and push secrets for an OpenShift S2I build, right ?

If so, we should indeed extend the configuration and implement this like @FlorianBois suggests.

I suggest to close this PR and work on the diff referenced above. @FlorianBois could you please create a PR and we can then discuss over there about the naming, timeout configuration and registry handling ?