Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark crd spec as required #3096

Open
shawkins opened this issue May 10, 2021 · 12 comments
Open

Mark crd spec as required #3096

shawkins opened this issue May 10, 2021 · 12 comments

Comments

@shawkins
Copy link
Contributor

When extending CustomResource I would like to mark the spec as required. The NotNull annotation however only seems to work on fields, and not methods, so this does not seem possible.

cc @metacosm

@metacosm
Copy link
Collaborator

Damn! 😓

@stale
Copy link

stale bot commented Aug 8, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale
Copy link

stale bot commented Nov 7, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale
Copy link

stale bot commented Feb 6, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Feb 6, 2022
@stale stale bot closed this as completed Feb 13, 2022
@manusa
Copy link
Member

manusa commented Feb 14, 2022

Hi @metacosm, @shawkins,

Was this already fixed? is it still applicable?

@manusa manusa reopened this Feb 14, 2022
@stale stale bot removed the status/stale label Feb 14, 2022
@metacosm
Copy link
Collaborator

No, this hasn't been fixed but not sure how important it is

@shawkins
Copy link
Contributor Author

No, this hasn't been fixed but not sure how important it is

It's just a nice to have for completeness.

@metacosm
Copy link
Collaborator

We could put the @NotNull annotation on the spec field of CustomResource, though that might be a little heavy-handed…

@stale
Copy link

stale bot commented May 15, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label May 15, 2022
@stale stale bot closed this as completed May 22, 2022
@manusa manusa reopened this May 22, 2022
@stale stale bot removed the status/stale label May 22, 2022
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@manusa
Copy link
Member

manusa commented Mar 5, 2024

Regarding version 7.0, one of the ideas is to completely remove CustomResource class in favor of specific interfaces for HasSpec, HasStatus, and so on (#2829 comment).

I'm not sure how this issue might play in conjunction with these interfaces.

Thoughts?

@manusa manusa added the Waiting on feedback Issues that require feedback from User/Other community members label Mar 5, 2024
@metacosm
Copy link
Collaborator

metacosm commented Mar 6, 2024

I guess having something implements the HasSpec interface would need to trigger the required clause on the spec. Same thing for HasStatus.

@metacosm metacosm removed their assignment Mar 6, 2024
@manusa manusa removed the Waiting on feedback Issues that require feedback from User/Other community members label Mar 6, 2024
@manusa manusa added this to the 7.0.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants