Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Go model generation for openshift-model-storageversionmigrator #6272

Closed
manusa opened this issue Aug 14, 2024 · 0 comments · Fixed by #6410
Closed

Replace Go model generation for openshift-model-storageversionmigrator #6272

manusa opened this issue Aug 14, 2024 · 0 comments · Fixed by #6410
Assignees
Labels
component/openshift-model Deals with Red Hat OpenShift Model
Milestone

Comments

@manusa
Copy link
Member

manusa commented Aug 14, 2024

Description

Part of #6130

Replace model generation for openshift-model-storageversionmigrator module with new OpenAPI approach.

Note

For OpenShift models there are going to be multiple conflicts with the previously generated code.
The openapi-generator won't reuse some of the types since OpenShift's OpenAPI spec hasn't got shared references and model types are defined inline.

Tasks

  • Remove build-helper-maven-plugin
  • Remove maven-antrun-plugin from the generate profile
  • Add openapi-model-generator-maven-plugin to the generate profile
  • Configure the plugin to generate the specific classes
  • Remove the go-related files and directories (Makefile, cmd)
  • Remove invocation from the generateModel.sh script
@manusa manusa added the component/openshift-model Deals with Red Hat OpenShift Model label Aug 14, 2024
@manusa manusa added this to the 7.0.0 milestone Aug 14, 2024
@manusa manusa moved this to In Progress in Eclipse JKube Oct 3, 2024
@manusa manusa self-assigned this Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/openshift-model Deals with Red Hat OpenShift Model
Projects
None yet
1 participant