Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: Add missing buildable references #6451

Closed
manusa opened this issue Oct 15, 2024 · 0 comments · Fixed by #6486
Closed

OpenAPI: Add missing buildable references #6451

manusa opened this issue Oct 15, 2024 · 0 comments · Fixed by #6486
Assignees
Labels
component/extensions Deals with the extensions component/kubernetes-model Deals with the kubernetes-model component/openshift-model Deals with Red Hat OpenShift Model
Milestone

Comments

@manusa
Copy link
Member

manusa commented Oct 15, 2024

Description

Part of #6130

Add missing buildable references to OpenAPI Maven Plugin.

@BuildableReference(EnvVar.class),
@BuildableReference(ContainerPort.class),
@BuildableReference(Volume.class),
@BuildableReference(VolumeMount.class)

These references were added only to the Kubernetes extensions since the go model generators and annotators were different for Kubernetes and OpenShift core model types and for the extensions.

We should address this and add these references in all cases by leveraging the new model generation approach.
These seem like interesting classes that will likely improve the Sundrio builder experience.

@manusa manusa added component/extensions Deals with the extensions component/kubernetes-model Deals with the kubernetes-model component/openshift-model Deals with Red Hat OpenShift Model labels Oct 15, 2024
@manusa manusa moved this to In Progress in Eclipse JKube Oct 23, 2024
@manusa manusa self-assigned this Oct 23, 2024
@manusa manusa added this to the 7.0.0 milestone Oct 23, 2024 — with automated-tasks
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/extensions Deals with the extensions component/kubernetes-model Deals with the kubernetes-model component/openshift-model Deals with Red Hat OpenShift Model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant