Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No initiation instructions! #13

Open
morkeltry opened this issue Dec 1, 2017 · 1 comment
Open

No initiation instructions! #13

morkeltry opened this issue Dec 1, 2017 · 1 comment

Comments

@morkeltry
Copy link

If you run it on a clean machine, you get:
Error: Environment variable DB_URL must be set

Instructions in the Readme would get your reviewers up and running more quickly!
@morkeltry
Copy link
Author

Unfortunately, I was unable to run it locally - too much database setup would have eaten into more code review time.
Testing the db locally would allow me to check the error logs for various kinds of injections. Eg, I'm not sure where you're catching ' so I don't know if it's secure or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morkeltry