Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlScrapper.js: if/else statement can be a bit fragile #42

Open
m4v15 opened this issue Jan 14, 2018 · 0 comments
Open

urlScrapper.js: if/else statement can be a bit fragile #42

m4v15 opened this issue Jan 14, 2018 · 0 comments

Comments

@m4v15
Copy link

m4v15 commented Jan 14, 2018

Here Atm it's not massively scaleable, if you wanted to add more sites or something in the future. Could use something like the url module to parse the url and then having a object with keys relating to the sites, and values being their relative url scraper - a bit like this vanilla node router from one of the fac workshops

@m4v15 m4v15 changed the title url scrap, if/else statement can be a bit fragile urlScrapper.js: if/else statement can be a bit fragile Jan 14, 2018
@jamiecoe jamiecoe mentioned this issue Jan 15, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant