Cast monetary node values to integers first

fac · Nov 4, 2014 · 978d78b · 978d78b
1 parent 5320351
commit 978d78b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/hermod/xml_section_builder.rb b/lib/hermod/xml_section_builder.rb
@@ -152,7 +152,8 @@ def monetary_node(name, options={})
       end
 
       create_method(name, [], validators, options) do |value, attributes|
-        if (options[:optional] && value == 0) || value.blank?
+        value = value.to_i
+        if options[:optional] && value == 0
           [nil, attributes]
         else
           [sprintf(format_for(:money), value), attributes]

diff --git a/spec/hermod/xml_section_builder/monetary_node_spec.rb b/spec/hermod/xml_section_builder/monetary_node_spec.rb
@@ -52,9 +52,12 @@ module Hermod
         ex.message.must_equal "student_loan cannot be zero"
       end
 
-      it "should ignore blank nodes" do
+      it "should treat blank nodes as zero nodes" do
         subject.ni nil
-        nodes("NI").must_be_empty
+        value_of_node("NI").must_equal "0.00"
+
+        subject.tax nil
+        nodes("Tax").must_be_empty
       end
     end
   end