-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further abstraction #49
Labels
Comments
Apologies that this is exactly the same as @AlexandraOM's issue #48 |
Agreed. Your code is very readable and quite nice despite not being perfect. There is nothing annoying in it. But yes as indicated this could be in a for each loop. if you're doing something explicitly 3 times or more you should usually automate it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dom.js file is really beautifully organised, kudos.
Had some quick ideas for making your code more DRY/further abstracting some of the repetition.
But as I said, it's already really nice with lots of different functions calling each other as and when rather than a single massive block of code!
The text was updated successfully, but these errors were encountered: