From 43d56e317cbf730c59589c79b73e09d65cdb2fda Mon Sep 17 00:00:00 2001
From: Bryan Housel <bhousel@gmail.com>
Date: Mon, 21 Oct 2024 18:04:00 -0400
Subject: [PATCH] Remove the UISpinner, it's been set to hidden forever

---
 modules/core/UiSystem.js |  7 +------
 modules/ui/index.js      |  1 -
 modules/ui/spinner.js    | 21 ---------------------
 3 files changed, 1 insertion(+), 28 deletions(-)
 delete mode 100644 modules/ui/spinner.js

diff --git a/modules/core/UiSystem.js b/modules/core/UiSystem.js
index 527974d98..ca3e24bae 100644
--- a/modules/core/UiSystem.js
+++ b/modules/core/UiSystem.js
@@ -10,7 +10,7 @@ import {
   uiInfo, uiIntro, uiIssuesInfo, uiLoading, UiMapInMap,
   uiMap3dViewer, UiPhotoViewer, uiRapidServiceLicense,
   uiSplash, uiRestore, uiScale, uiShortcuts, UiSidebar,
-  uiSourceSwitch, UiSpector, uiSpinner, uiStatus, uiTooltip,
+  uiSourceSwitch, UiSpector, uiStatus, uiTooltip,
   uiTopToolbar, uiVersion, uiWhatsNew, uiZoom, uiZoomToSelection
 } from '../ui/index.js';
 
@@ -263,11 +263,6 @@ export class UiSystem extends AbstractSystem {
     $$overmap
       .call(uiMap3dViewer(context));
 
-    $$overmap
-      .append('div')
-      .attr('class', 'spinner')
-      .call(uiSpinner(context));
-
     $$overmap
       .call(this.spector.render);
 
diff --git a/modules/ui/index.js b/modules/ui/index.js
index 9a03d2a59..940cfd37a 100644
--- a/modules/ui/index.js
+++ b/modules/ui/index.js
@@ -67,7 +67,6 @@ export { uiShortcuts } from './shortcuts.js';
 export { UiSidebar } from './UiSidebar.js';
 export { uiSourceSwitch } from './source_switch.js';
 export { UiSpector } from './UiSpector.js';
-export { uiSpinner } from './spinner.js';
 export { uiSplash } from './splash.js';
 export { uiStatus } from './status.js';
 export { uiSuccess } from './success.js';
diff --git a/modules/ui/spinner.js b/modules/ui/spinner.js
deleted file mode 100644
index 594118287..000000000
--- a/modules/ui/spinner.js
+++ /dev/null
@@ -1,21 +0,0 @@
-export function uiSpinner(context) {
-  const assets = context.systems.assets;
-  const osm = context.services.osm;
-
-  return function(selection) {
-    const img = selection
-      .append('img')
-      .attr('src', assets.getFileURL('img/loader-black.gif'))
-      .style('opacity', 0);
-
-    if (osm) {
-      osm
-        .on('loading.spinner', function() {
-          img.transition().style('opacity', 1);
-        })
-        .on('loaded.spinner', function() {
-          img.transition().style('opacity', 0);
-        });
-    }
-  };
-}