Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAD dataset doesn't show up in canary #1653

Closed
emersonveenstra opened this issue Dec 21, 2024 · 1 comment
Closed

NAD dataset doesn't show up in canary #1653

emersonveenstra opened this issue Dec 21, 2024 · 1 comment
Labels
bug-regression It worked before but now it doesn't 🐤 canary Issue only exists in canary

Comments

@emersonveenstra
Copy link
Contributor

Description

Enabling the NAD dataset doesn't display any of the dataset points, even though it does in 2.4.3.

Screenshots

No response

Version

canary

What browser are you seeing the problem on? What version are you running?

No response

The OS you're using

No response

Steps to reproduce

  1. Go to https://rapideditor.org/edit#map=18.33/43.02353/-108.38127&background=Bing&datasets=e75b56f13b404d7d8b47ef8be1c619ec,fbRoads,msBuildings&disable_features=boundaries
  2. Observe the NAD dataset points
  3. Go to https://rapideditor.org/canary#map=18.33/43.02353/-108.38127&background=Bing&datasets=e75b56f13b404d7d8b47ef8be1c619ec,fbRoads,msBuildings&disable_features=boundaries
  4. Observe the lack of NAD points

The browser URL at the time you encountered the bug

https://rapideditor.org/canary#map=18.33/43.02353/-108.38127&background=Bing&datasets=e75b56f13b404d7d8b47ef8be1c619ec,fbRoads,msBuildings&disable_features=boundaries

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

@bhousel bhousel added bug-regression It worked before but now it doesn't 🐤 canary Issue only exists in canary labels Dec 23, 2024
@bhousel
Copy link
Contributor

bhousel commented Dec 23, 2024

Thanks for catching @emersonveenstra - I realize this regressed in #1642
There is an extra step that we need to run for the Esri datasets where we fetch the dataset's schema from a different url. This previously happened in the UI code, but now the responsibility for doing that step needs to move to the EsriService code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-regression It worked before but now it doesn't 🐤 canary Issue only exists in canary
Projects
None yet
Development

No branches or pull requests

2 participants