Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in Tabs is not searchable #5344

Closed
tmuskin opened this issue Aug 11, 2021 · 2 comments
Closed

Text in Tabs is not searchable #5344

tmuskin opened this issue Aug 11, 2021 · 2 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.

Comments

@tmuskin
Copy link

tmuskin commented Aug 11, 2021

🐛 Bug Report

Description

Some pages are using tabs to organize information. We are using docusaurus-lunr-search as our search engine. When we try searching for information that is in the tabs it does not show in the search results.

Have you read the Contributing Guidelines on issues?

Yes.

Steps to reproduce

  1. Go go CodeSandbox
  2. Try to search for anything that is underneath a tab section (there are tabs in the Tab Bug section under tutorial)

Expected behavior

Information that is in tabs is searched for and comes up in the search results

Actual behavior

The tabs pages do not come up in the search results

Your environment

Search engine is generated using docusaurus-lunr-search
Tabs are created using the documentation on tabs from Docusarus

Reproducible demo

See CodeSandbox and try to search for information that is underneath tabs.

@tmuskin tmuskin added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Aug 11, 2021
@slorber
Copy link
Collaborator

slorber commented Aug 12, 2021

Hi,

Lunr is not an official Docusaurus core plugin and we don't provide support for it.

What you can see is that all the tabs content is in the static HTML file (unless you use the lazy=true prop):

image

This is the responsibility of the Lunr plugin to index correctly the content of hidden tabs, and you should report the issue on the plugin repo directly. I can help the plugin author if needed.

Your repro does not include the lunr plugin so I can't see the issue in practice.

@tmuskin
Copy link
Author

tmuskin commented Aug 12, 2021

I reported it in the plugin repo here and included the plugin to my repro.

@Josh-Cena Josh-Cena added external This issue is caused by an external dependency and not Docusaurus. and removed status: needs triage This issue has not been triaged by maintainers labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.
Projects
None yet
Development

No branches or pull requests

3 participants