Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail to build with libc++ 19 and above #2367

Open
sin-ack opened this issue Jan 12, 2025 · 0 comments
Open

Tests fail to build with libc++ 19 and above #2367

sin-ack opened this issue Jan 12, 2025 · 0 comments

Comments

@sin-ack
Copy link

sin-ack commented Jan 12, 2025

The following code fails to build:

testRandom<std::basic_string<signed char>>();

Because libc++ removed its deprecated std::char_traits base template as of version 19: https://releases.llvm.org/19.1.0/projects/libcxx/docs/ReleaseNotes.html#deprecations-and-removals

The base template for std::char_traits has been removed in LLVM 19. If you are using std::char_traits with types other than char, wchar_t, char8_t, char16_t, char32_t or a custom character type for which you specialized std::char_traits, your code will stop working. The Standard does not mandate that a base template is provided, and such a base template is bound to be incorrect for some types, which could currently cause unexpected behavior while going undetected.

System information

OS: Gentoo Linux amd64 (x86_64-pc-linux-gnu)
Compiler: clang version 19.1.4+libcxx
C++ stdlib implementation: libc++
Folly version: 2025.01.06.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant