From 47bbe47824be9009380a05b6d7cb38f7332596a1 Mon Sep 17 00:00:00 2001 From: joker Date: Fri, 15 May 2020 13:50:46 +0800 Subject: [PATCH] git checkout "fix #2497" --- .../facebook/datasource/AbstractDataSource.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java b/fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java index 470391e049..e8dcd8f909 100644 --- a/fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java +++ b/fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java @@ -164,30 +164,26 @@ public void subscribe(final DataSubscriber dataSubscriber, final Executor exe } if (shouldNotify) { - notifyDataSubscriber(dataSubscriber, executor, hasFailed(), wasCancelled()); + notifyDataSubscriber(dataSubscriber, executor); } } private void notifyDataSubscribers() { - final boolean isFailure = hasFailed(); - final boolean isCancellation = wasCancelled(); for (Pair, Executor> pair : mSubscribers) { - notifyDataSubscriber(pair.first, pair.second, isFailure, isCancellation); + notifyDataSubscriber(pair.first, pair.second); } } protected void notifyDataSubscriber( final DataSubscriber dataSubscriber, - final Executor executor, - final boolean isFailure, - final boolean isCancellation) { + final Executor executor) { Runnable runnable = new Runnable() { @Override public void run() { - if (isFailure) { + if (AbstractDataSource.this.hasFailed()) { dataSubscriber.onFailure(AbstractDataSource.this); - } else if (isCancellation) { + } else if (AbstractDataSource.this.wasCancelled()) { dataSubscriber.onCancellation(AbstractDataSource.this); } else { dataSubscriber.onNewResult(AbstractDataSource.this);