{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":455600,"defaultBranch":"master","name":"hhvm","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-01-02T01:17:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708115215.0","currentOid":""},"activityList":{"items":[{"before":"c2ce62ba7a19a22e7ee4e7ca5312c67ff7666350","after":"1d96b9a07d67b06c4e5439c2bc8ff31a83402083","ref":"refs/heads/master","pushedAt":"2024-07-04T17:22:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Unify lib/cpp2/async targets\"\n\nSummary:\nReason increased binary size: https://fb.workplace.com/groups/thriftusers/permalink/1426747141368027/\n\nOriginal commit changeset: da8fc7887027\n\nOriginal Phabricator Diff: D59281705\n\nReviewed By: vitaut, YanNoun\n\nDifferential Revision: D59373466\n\nfbshipit-source-id: 63c9d9f577557e63b8a9548f8419952d81430a92","shortMessageHtmlLink":"Back out \"Unify lib/cpp2/async targets\""}},{"before":"55e0af2aac18717582c6a682ff5903f9bff5eb3f","after":"c2ce62ba7a19a22e7ee4e7ca5312c67ff7666350","ref":"refs/heads/master","pushedAt":"2024-07-04T16:37:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/66b37666c3a6edca4610fb3e625a8ac06fb3a06d\nhttps://github.com/facebook/fb303/commit/22ea90095229494ac7ff578c47919c244ff623fb\nhttps://github.com/facebook/fbthrift/commit/c6c5564e281668105d0a2dbd99616b8aac615487\nhttps://github.com/facebook/folly/commit/19e4d49f84134c2e41f5cdf4597a338b68928028\nhttps://github.com/facebook/mvfst/commit/709d45797653cfbc3f7c14cf3bf5b8d12a759119\nhttps://github.com/facebook/proxygen/commit/3e4086117d4ad93bfd7ad2bfc1f0b2f148cec0f6\nhttps://github.com/facebook/wangle/commit/c309dd35bd7f00f712ca04abd07ade4a76216120\nhttps://github.com/facebookexperimental/edencommon/commit/fe5fe5a2b3567b8eef2d63ddd9053fc7800657ca\nhttps://github.com/facebookexperimental/rust-shed/commit/76d39cb91a3abbf3eb8f569ab12ec350bc9a5489\nhttps://github.com/facebookincubator/fizz/commit/b6d0e1a01ecaa365de8f6afa52bfe58f6a2c957c\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: e96c71adb89c7938c85265ac85873e1f16cc1f6d","shortMessageHtmlLink":"Updating submodules"}},{"before":"2be4d998fd15f6e052e7527999dc4e8016531c96","after":"55e0af2aac18717582c6a682ff5903f9bff5eb3f","ref":"refs/heads/master","pushedAt":"2024-07-04T11:13:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a helper for querying ELF hardware capabilities\n\nSummary:\nELF platforms provide some indication of hardware capabilities via the auxilary vector (auxv).\n\nAdd a helper to query these capabilities at runtime, modelled after folly::CpuId, but explicitly multi-platform.\n\nThis helper is unsuitable for use on `x86-64`, as `glibc` massages the values presented to the point that they're unusable. On `x86-64` platforms you should continue to use `folly::CpuId`.\n\nDifferential Revision: D59320930\n\nfbshipit-source-id: a4ffd304415039440a8e714103266b1f37987a8e","shortMessageHtmlLink":"Add a helper for querying ELF hardware capabilities"}},{"before":"78fc61ca45714bddfa2ef3bcda0b118fad5b74c5","after":"2be4d998fd15f6e052e7527999dc4e8016531c96","ref":"refs/heads/master","pushedAt":"2024-07-04T01:16:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix usage of declval\n\nSummary: It doesn't make sense to call `std::declval` with an rvalue reference because it adds one itself: https://en.cppreference.com/w/cpp/utility/declval. Moreover this occasionally crashes the MSVC compiler. Fix it.\n\nReviewed By: yoney\n\nDifferential Revision: D59331618\n\nfbshipit-source-id: 067ac0996965967576d5e1946b6bbac27d494df5","shortMessageHtmlLink":"Fix usage of declval"}},{"before":"3c9a2a4a23cd1f3f084966b985139a7e938cb1c7","after":"78fc61ca45714bddfa2ef3bcda0b118fad5b74c5","ref":"refs/heads/master","pushedAt":"2024-07-04T00:56:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Adjust Delegated cred serialization to not have fizz in label\n\nSummary: As title says, currently not in use so should be fine. We may extend to non fizz impls so we should drop the specifier.\n\nReviewed By: knekritz\n\nDifferential Revision: D59342616\n\nfbshipit-source-id: 919979e2b090a1e79356fe663a66e1f98e82a94f","shortMessageHtmlLink":"Adjust Delegated cred serialization to not have fizz in label"}},{"before":"86f68f1f9183a88b64e27673521e7261b99fbd95","after":"3c9a2a4a23cd1f3f084966b985139a7e938cb1c7","ref":"refs/heads/master","pushedAt":"2024-07-04T00:16:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"EnumClass\\Label Should Not Allow References to Type Constants\n\nSummary:\n# Context\nFor every type constant `T` we create a constant definition with the same name as the type constant with type `TypeStructure<this::T>`. When type constants were added to enum classes, the label code did not filter out these constants. The new label inference repeated this mistake. This diff is meant to fix it.\n\n# Mitigation\nThe fix is to filter out type constants within Typing_subtype.Has_const\n\nWhile doing this I realized there was a bug introduced by D55829619 where if no quick fixes were produced we wouldn't report an error. I fixed this and added a test case\n\nReviewed By: francesco-zappa-nardelli\n\nDifferential Revision: D59340204\n\nfbshipit-source-id: b64d868a62441e3a767795ad2b8ce83312a810fb","shortMessageHtmlLink":"EnumClass\\Label Should Not Allow References to Type Constants"}},{"before":"a9e7179fb18cc837fbb94d604fd431d5e0e5f04c","after":"86f68f1f9183a88b64e27673521e7261b99fbd95","ref":"refs/heads/master","pushedAt":"2024-07-03T23:22:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Unify lib/cpp2/async targets\n\nReviewed By: yoney, kaczmarekmhl\n\nDifferential Revision: D59281705\n\nfbshipit-source-id: da8fc788702739caed8becb270a09ee305272a00","shortMessageHtmlLink":"Unify lib/cpp2/async targets"}},{"before":"71635cefc9f99accef87c77961417bd87ae1446b","after":"a9e7179fb18cc837fbb94d604fd431d5e0e5f04c","ref":"refs/heads/master","pushedAt":"2024-07-03T21:57:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use init_priority to make sure jemalloc is set up early when using clang\n\nSummary: We used it for gcc builds but not clang for no obvious reason. Tried clang and confirmed it supports the attribute.\n\nReviewed By: ricklavoie\n\nDifferential Revision: D59306333\n\nfbshipit-source-id: 97e98d7e6228582f22cf299d5fcef71c797d1def","shortMessageHtmlLink":"use init_priority to make sure jemalloc is set up early when using clang"}},{"before":"da4cda83e14c975dfbb49df9731202b3d3d3d803","after":"71635cefc9f99accef87c77961417bd87ae1446b","ref":"refs/heads/master","pushedAt":"2024-07-03T21:29:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D58253704: make List__ containers pure python\n\nDifferential Revision:\nD58253704\n\nOriginal commit changeset: 7f221b28e7e0\n\nOriginal Phabricator Diff: D58253704\n\nfbshipit-source-id: b199b3603ae84c5cbb219897defca7e22ea89881","shortMessageHtmlLink":"Revert D58253704: make List__ containers pure python"}},{"before":"9fbef64f53f9d8b3f7e55ea9de0e3e2341ceb07d","after":"da4cda83e14c975dfbb49df9731202b3d3d3d803","ref":"refs/heads/master","pushedAt":"2024-07-03T21:16:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"icsp_any: generalize ensure_thrift_any_type a bit\n\nSummary:\none might hope that if you wrote a program like this\n```\n  4     let foo = foo::Foo { bar: 42 };\n  5     let any: any::Any = icsp_any::serialize(&foo);\n  6     match icsp_any::deserialize::<foo::Bar>(&any) {\n  7         Ok(_) => (),\n  8         Err(e) => println!(\"error:\\n{:#?}\", e),\n  9     }\n```\nor this,\n```\n 11     let bar = foo::Bar::x(\"hello\".to_owned());\n 12     let any: any::Any = icsp_any::serialize(&bar);\n 13     match icsp_any::deserialize::<foo::Foo>(&any) {\n 14         Ok(_) => (),\n 15         Err(e) => println!(\"error:\\n{:#?}\", e),\n 16     }\n```\nthat errors would be printed but that's not how deserialization works (well defined and valid thrift values are produced by both).\n\nto help avoid head-scratching from this kind of \"type mismatch\" there exists the utility `ensure_thrift_any_type<T>` which is called before any deserialization happens at the start of `icsp_any::deserialize()`.\n\nhowever, as indicated by [this comment](https://www.internalfb.com/code/fbsource/[7a25a4e79650]/fbcode/syx/common/thrift_any/src/deserialize.rs?lines=48-49), `ensure_thrift_any_type<T>` doesn't consider the case of `TypeUri`s containing hash prefixes of uri strings and so the check was disabled in the syx fork of icsp_any since this was shown to be incompatible with their python clients.\n\nthis diff improves `ensure_thrift_any_type<T>` such that in a subsequent diff we can unfork `syx_thrift_any::deserialize()`.\n\nReviewed By: dtolnay\n\nDifferential Revision: D59336510\n\nfbshipit-source-id: 804c82b9c6604cfdc697dc60bff0b6f2aa157c02","shortMessageHtmlLink":"icsp_any: generalize ensure_thrift_any_type a bit"}},{"before":"0b2bb99f7823b5a5ce44801fa4ca6a3c069f49ab","after":"9fbef64f53f9d8b3f7e55ea9de0e3e2341ceb07d","ref":"refs/heads/master","pushedAt":"2024-07-03T19:56:00.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"allow creation of MCP context\n\nReviewed By: jano\n\nDifferential Revision: D58206664\n\nfbshipit-source-id: b69950a8cc28d72f5f7ce2ef8dcf452ea036bd2f","shortMessageHtmlLink":"allow creation of MCP context"}},{"before":"4230e355464581b5d67acede74da7119674a3fc9","after":"0b2bb99f7823b5a5ce44801fa4ca6a3c069f49ab","ref":"refs/heads/master","pushedAt":"2024-07-03T19:25:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make List__ containers pure python\n\nSummary:\nMake the List__ types pure python to save some binary size and build time.\n\n**__Context__**:\nThis is the first big step of 4 to remove most lines of generated cython from thrift-py3. [Doc here](https://docs.google.com/document/d/1a_t1FXVktpildN2CN9kHE6CmxU732PE-rJR75tCBgM8/edit?usp=sharing).\n\n__Code Complexity__:\nThis reduces the complexity of generated cython. In the short-run, we take a hit on mustache template complexity, but we'll get all this back once all containers (Set, Map) follow the pattern from this diff.\n\n__Suggested review order__:\nMight be easiest to look at changes to `thrift/lib/py3/types.pyx` `List` first. Some refactoring to avoid any need for `cdef` methods in generated `List__` children.\n\n__Improves cython cxx compilation time__\n\n**13% faster**: for one infamous skynet target. The actual effect dependson how many `list<_>` a thrift IDL contains.\n\n```\nbuck2 build @//mode/opt //nettools/skynet/if:skynet_structs_cross_db_apps-py3-types/SkynetStructs_CrossDbApps/types\n```\n\nOver the last week, buck2 spent 8683768s (2412 hr) waiting on this target: https://fburl.com/scuba/buck2_critical_path_actions/jtf1u7lw\n\nIn other words, buck2 is spending 60 weeks / week  waiting for this target to build. Therefore, this diff saves 12.8% = 7.7 compilation years / year. There is some complicated formula to weigh this for async builds, but we can simplify by just looking at user buck2 invocations:\n\n321 invocations / wk * 222 second / invocation = 19.8 hours / wk saved => **0.5 EYS / yr for a single target**\nhttps://fburl.com/scuba/buck2_critical_path_actions/lxutsb8j\n\nTiming procedure:\n1. run above command\n2. `buck2 log what-ran`. Get action digest of `cxx_compile` step (second to last)\n3. `frecli cas download-action $hash`\n4. `time /tmp/recli.wJUxpF/exe` (from previous command)\n\n`types.cpp` compilation time this diff\n```\nreal    25m5.438s\nuser    24m29.995s\nsys     0m13.588s\n```\n\n`types.cpp` compilation time on fbcode/warm\n```\nreal    28m47.185s\nuser    28m21.973s\nsys     0m16.355s\n```\n\nBasic sanity check on `buck2 build @//mode/opt //thrift/lib/py3/test:testing-py3-types/testing/types`\n\nIgnoring effect on cython compiler time (10s), which is actually faster in `@//mode/opt`, we see 9% compile-time speedup on `cxx_compile` step (heaviest one).\n\nV1: Cpp compile time:\n```\nreal    0m59.097s\nuser    0m57.662s\nsys     0m1.100s\n```\n\nTrunk: Cpp compile time:\n```\nreal    1m5.110s\nuser    1m3.490s\nsys     0m1.165s\n```\n\nV6: # buildall\n\nReviewed By: Filip-F\n\nDifferential Revision: D58253704\n\nfbshipit-source-id: 7f221b28e7e09954eac8c0ef7c561b963592820d","shortMessageHtmlLink":"make List__ containers pure python"}},{"before":"372c6227870f20a35211d18184de19815e6901ef","after":"4230e355464581b5d67acede74da7119674a3fc9","ref":"refs/heads/master","pushedAt":"2024-07-03T19:02:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Escape DEL when rendering string values\n\nSummary:\nThis control character is sometimes used to represent deleting the\ncharacter before it, and is questionably printable. Escape it like other\nspecial characters.\n\nReviewed By: yoney\n\nDifferential Revision: D59302298\n\nfbshipit-source-id: 0b9f8f9fb406d348683c9ad482231cb72fac9a8f","shortMessageHtmlLink":"Escape DEL when rendering string values"}},{"before":"5d83b68f661e7abc2c878270adc93ce8cbce5fc1","after":"372c6227870f20a35211d18184de19815e6901ef","ref":"refs/heads/master","pushedAt":"2024-07-03T17:54:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add usecase ID in MC request\n\nSummary: In order to support long retention in ucache, we need CacheClient pass usecase ID (DT ID) in MC request so that server could determine which flash arena to use.\n\nReviewed By: alikhtarov\n\nDifferential Revision: D59289080\n\nfbshipit-source-id: f24da922a59637793823c872eab9fe1474d8cf73","shortMessageHtmlLink":"Add usecase ID in MC request"}},{"before":"69d2da7201e49413e0b468aa62afa7302e60dd6e","after":"5d83b68f661e7abc2c878270adc93ce8cbce5fc1","ref":"refs/heads/master","pushedAt":"2024-07-03T17:02:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove outdated comment in StaticMeta\n\nSummary: The comment was from an earlier version of diff but should have been removed before the diff landed.\n\nDifferential Revision: D59329972\n\nfbshipit-source-id: 59b4e842ae6e235a4f2b705704949d662ca78d29","shortMessageHtmlLink":"remove outdated comment in StaticMeta"}},{"before":"75d1edfa3c46b82803a0727a5975e60378741941","after":"69d2da7201e49413e0b468aa62afa7302e60dd6e","ref":"refs/heads/master","pushedAt":"2024-07-03T16:38:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/906dfb14632346e34200d685b898a541790df4d9\nhttps://github.com/facebook/fb303/commit/2e0a124b66a15f131263072052ad6970f3cfafe5\nhttps://github.com/facebook/fbthrift/commit/dcf0b6ccdba3773387f892764ddc2c8f6477fe50\nhttps://github.com/facebook/folly/commit/d31f1b0fdc4d74fb1ed7fae94f7c6f88e0943a34\nhttps://github.com/facebook/mvfst/commit/5e79559d947160dc105066f9b9c068079c46ad95\nhttps://github.com/facebook/proxygen/commit/3dfff8fb84f3ea492520206665a9222e55151b8c\nhttps://github.com/facebook/wangle/commit/66a71669eeaab1ea3118eab046090805eccfbc61\nhttps://github.com/facebookexperimental/edencommon/commit/4fcb9b138da9d8629ae5fef66308b362b52116b4\nhttps://github.com/facebookexperimental/rust-shed/commit/6ee0656e0a17136dfc7d9fe37fdb7c457205c6bf\nhttps://github.com/facebookincubator/fizz/commit/a244c8044eb1dd69f07036667f119afac1dc5435\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 29dbbe4e446c739c6b400cec7b0c94a9f1dd104f","shortMessageHtmlLink":"Updating submodules"}},{"before":"b83f4cbca2d9a116bad25164d136096ae6cbb806","after":"75d1edfa3c46b82803a0727a5975e60378741941","ref":"refs/heads/master","pushedAt":"2024-07-03T16:28:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove alternate server job-queue dequeue limiter\n\nSummary: This is not in use and not planned for use either.\n\nReviewed By: mdko\n\nDifferential Revision: D59284092\n\nfbshipit-source-id: dd397b2a463d17cea7e80ad8e4ebdf29a1b3805a","shortMessageHtmlLink":"Remove alternate server job-queue dequeue limiter"}},{"before":"84a8fdc1ef436e7032cb994250331f6f85d419ea","after":"b83f4cbca2d9a116bad25164d136096ae6cbb806","ref":"refs/heads/master","pushedAt":"2024-07-03T16:22:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Applying BLACK formatting\n\nSummary:\nRemoved fbcode/hphp/tools from the BLACK opt-outs and applied formatting\nWith:\n    hg files fbcode/hphp/tools | arc lint --take BLACK --apply-patches -\n\nReviewed By: zertosh\n\nDifferential Revision: D59278743\n\nfbshipit-source-id: a3c4984864084ac2e56215cf359fba2d5c6bcf8b","shortMessageHtmlLink":"Applying BLACK formatting"}},{"before":"3ba747877180afa6c34440c6eb250769e1564aa1","after":"84a8fdc1ef436e7032cb994250331f6f85d419ea","ref":"refs/heads/master","pushedAt":"2024-07-03T16:02:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"CI: enable clang tests (#898)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/zstrong/pull/898\n\nReviewed By: malanka\n\nDifferential Revision: D59065671\n\nfbshipit-source-id: 2a09ae13e1d4c62a7b9a907cca0e911672435ad1","shortMessageHtmlLink":"CI: enable clang tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"17279060\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hhvm/issues/898\" data-hovercard-type=\"issue\" data-hovercard-url=\"/facebook/hhvm/issues/898/hovercard\" href=\"https://github.com/facebook/hhvm/issues/898\">#898</a>)"}},{"before":"ce7b729172021305f2fd6f9e3277835f1658bd34","after":"3ba747877180afa6c34440c6eb250769e1564aa1","ref":"refs/heads/master","pushedAt":"2024-07-03T14:53:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix filtering of where clauses when constraints involve function types\n\nSummary:\nOn `filter_where_clauses_08.php` below the autocomplete incorrectly did not suggest `notToThrow` because `Typing_phase.check_where_constraints` could not unify the types:\n\n```\ncstr_ty: (function(): ~#0)\nty: (function(): void)\n```\n\nThis diff strips the `~` from the return type of the (toplevel) function types appearing in the where constraints.  The test `filter_where_clauses_08.php` now correctly suggests `notToThrow`.\n\nReviewed By: madgen\n\nDifferential Revision: D59223732\n\nfbshipit-source-id: b52b8ddfe7eba4c7bda0ab8c07cf099d37de8bc1","shortMessageHtmlLink":"fix filtering of where clauses when constraints involve function types"}},{"before":"47a09b770ad667a4ee53291ce0218a1e1ac64064","after":"ce7b729172021305f2fd6f9e3277835f1658bd34","ref":"refs/heads/master","pushedAt":"2024-07-03T14:04:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make Polly work with MSVC\n\nSummary: MSVC fails to deduce template parameter for a `get` call when the argument is inherited from `std::tuple`. Workaround this by converting the argument to tuple explicitly.\n\nReviewed By: Orvid\n\nDifferential Revision: D59301411\n\nfbshipit-source-id: 61128b4599a78887ad52f6db6a1ff30e0f70df28","shortMessageHtmlLink":"Make Polly work with MSVC"}},{"before":"c9de7ac7358d07cb0d061f3a70ea2b3aed5ecb53","after":"47a09b770ad667a4ee53291ce0218a1e1ac64064","ref":"refs/heads/master","pushedAt":"2024-07-03T07:36:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add list[str] field access benchmark\n\nSummary:\n- Add a list string field benchmark\n- Transpose the tables for readability\n- fix some pyre crimes\n\nReviewed By: yoney\n\nDifferential Revision: D59312528\n\nfbshipit-source-id: e3a723b19c3242eee205bd0d2010e60616273703","shortMessageHtmlLink":"add list[str] field access benchmark"}},{"before":"20d9fe123f18804d21d706b7026798219d1735bc","after":"c9de7ac7358d07cb0d061f3a70ea2b3aed5ecb53","ref":"refs/heads/master","pushedAt":"2024-07-03T04:11:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"actually enable valuable on `tracing`\n\nSummary: I thought `valuable` was enabled; it wasn't. Let's *actually* enable it.\n\nReviewed By: Wilfred\n\nDifferential Revision: D59301882\n\nfbshipit-source-id: 60337d3b69f8babb4cd6f12d044fd2f856539056","shortMessageHtmlLink":"actually enable valuable on <code>tracing</code>"}},{"before":"cefe908cc538861a4047e9b2734ce6b2b2e0cd6c","after":"20d9fe123f18804d21d706b7026798219d1735bc","ref":"refs/heads/master","pushedAt":"2024-07-03T01:24:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix the union skip consumes double T_STOP\n\nSummary: The `skip()` function consumes a `T_STOP`, and if `readFieldBegin()` is called after `skip()`, it will consume another `T_STOP`. This cause an \"underflow\" exception.\n\nReviewed By: vitaut\n\nDifferential Revision: D59278369\n\nfbshipit-source-id: 884c6d1e7f2fdbd927a5358020867dd8c78a3de1","shortMessageHtmlLink":"Fix the union skip consumes double T_STOP"}},{"before":"ffc7d3505bc0ad3626b98949b02a083dce6aac5d","after":"cefe908cc538861a4047e9b2734ce6b2b2e0cd6c","ref":"refs/heads/master","pushedAt":"2024-07-03T01:14:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move coro to folly/coro\n\nSummary:\nThe following targets were moved to folly/coro:\n```\n//folly/experimental/coro:accumulate\n//folly/experimental/coro:async_generator\n//folly/experimental/coro:async_pipe\n//folly/experimental/coro:async_scope\n//folly/experimental/coro:async_stack\n//folly/experimental/coro:baton\n//folly/experimental/coro:blocking_wait\n//folly/experimental/coro:collect\n//folly/experimental/coro:concat\n//folly/experimental/coro:coroutine\n//folly/experimental/coro:current_executor\n//folly/experimental/coro:detach_on_cancel\n//folly/experimental/coro:detail_barrier\n//folly/experimental/coro:detail_barrier_task\n//folly/experimental/coro:detail_current_async_frame\n//folly/experimental/coro:detail_helpers\n//folly/experimental/coro:detail_malloc\n//folly/experimental/coro:detail_manual_lifetime\n//folly/experimental/coro:detail_traits\n//folly/experimental/coro:filter\n//folly/experimental/coro:future_util\n//folly/experimental/coro:generator\n//folly/experimental/coro:gmock_helpers\n//folly/experimental/coro:gtest_helpers\n//folly/experimental/coro:inline_task\n//folly/experimental/coro:invoke\n//folly/experimental/coro:merge\n//folly/experimental/coro:mutex\n//folly/experimental/coro:promise\n//folly/experimental/coro:result\n//folly/experimental/coro:retry\n//folly/experimental/coro:rust_adaptors\n//folly/experimental/coro:scope_exit\n//folly/experimental/coro:shared_lock\n//folly/experimental/coro:shared_mutex\n//folly/experimental/coro:sleep\n//folly/experimental/coro:small_unbounded_queue\n//folly/experimental/coro:task\n//folly/experimental/coro:timed_wait\n//folly/experimental/coro:timeout\n//folly/experimental/coro:traits\n//folly/experimental/coro:transform\n//folly/experimental/coro:unbounded_queue\n//folly/experimental/coro:via_if_async\n//folly/experimental/coro:with_async_stack\n//folly/experimental/coro:with_cancellation\n//folly/experimental/coro:bounded_queue\n//folly/experimental/coro:shared_promise\n//folly/experimental/coro:cleanup\n//folly/experimental/coro:auto_cleanup_fwd\n//folly/experimental/coro:auto_cleanup\n//folly/experimental/coro/test:async_generator_bench\n//folly/experimental/coro/test:async_stack_test\n//folly/experimental/coro/test:blocking_wait_bench\n//folly/experimental/coro/test:collect_all_benchmark\n//folly/experimental/coro/test:coro_benchmark_allocator\n//folly/experimental/coro/test:coro_benchmark_nrvo\n//folly/experimental/coro/test:coro_test\n//folly/experimental/coro/test:coroutine_test\n//folly/experimental/coro/test:generator_test\n//folly/experimental/coro/test:gmock_helpers_test\n//folly/experimental/coro/test:gtest_helpers_test\n//folly/experimental/coro/test:promise_benchmark\n//folly/experimental/coro/test:request_context_test\n//folly/experimental/coro/test:retry_test\n//folly/experimental/coro/test:shared_promise_test\n//folly/experimental/coro/test:suspended_stack_test\n//folly/experimental/coro/test:task_bench\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:mecoro2.folly\n\nReviewed By: yfeldblum\n\nDifferential Revision: D59249992\n\nfbshipit-source-id: ad73a3797845f01fac278b53f71a9f6ab4b02c5b","shortMessageHtmlLink":"Move coro to folly/coro"}},{"before":"a007e3210c3a45bcd8f5d25906afc82225717c19","after":"ffc7d3505bc0ad3626b98949b02a083dce6aac5d","ref":"refs/heads/master","pushedAt":"2024-07-03T00:40:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a test case to reproduce inefficient usage of DecReleaseCheck\n\nSummary:\nAdd a test PHP file whose TC print contains the inefficient IR for DecReleaseCheck. Sometimes, DecReleaseCheck is immediately preceded by an IncRef, but we don't currently have support for cancelling them out. See the following example from the test file's TC print:\n```\nB14: [profCount=8] (preds B39 B10)\n             t12:PtrToElem = phi t53:PtrToElem@B39, TV: 0x80010190@B10\n        (33) t12:PtrToElem = DefLabel\n        --- bc main(id 1078456160)57, fp 5, fixupFP 5, spOff 3,  [profTrans=3]\n        CGetQuietL L:2\n        (71) IncRef t10:Obj=Closure$main\n            Main:\n            0x1d0000cb: incl  (%r14)\n\n        --- bc main(id 1078456160)59, fp 5, fixupFP 5, spOff 3,  [profTrans=3]\n        FCallFunc <SkipRepack SkipCoeffectsCheck> 1 1 \"\" \"\" - \"\"\n        (77) t29:FramePtr = BeginInlining<IRSPOff -6 FUNC __invoke> t6:StkPtr\n\n        --- bc main(id 1078456160)59, fp 5, fixupFP 5, spOff 2,  [profTrans=3]\n        FCallFunc <SkipRepack SkipCoeffectsCheck> 1 1 \"\" \"\" - \"\"\n        (78) EnterInlineFrame t29:FramePtr\n\n        --- bc __invoke(id 1078456080)0e, fp 29, fixupFP 5, spOff 0,  [profTrans=4]\n        FuncEntry\n        (86) DecReleaseCheck t10:Obj=Closure$main -> B31\n            Main:\n            0x1d0000ce: cmpl  $0x1, (%r14)\n            0x1d0000d2: jnz 0x1d100004\n\n            Cold:\n            0x1d100004: jl 0x1d000054\n            0x1d10000a: decl  (%r14)\n            0x1d10000d: jmp 0x1d000054\n\n      -> B33\n\n     B33: [profCount=8] (preds B14)\n        --- bc main(id 1078456160)36, fp 5, fixupFP 5, spOff 0,  [profTrans=2]\n        IterInit <BaseConst> 0 NK V:0 L:1 76 (112)\n        (198) t63:Int = LdPtrIterVal<InitCell> vec(0x80010180)=Vanilla, t12:PtrToElem\n            Main:\n            0x1d0000d8: movq  (%r13), %rbx\n\n        --- bc __invoke(id 1078456080)0e, fp 29, fixupFP 5, spOff 0,  [profTrans=4]\n        FuncEntry\n        (90) ReleaseShallow t10:Obj=Closure$main\n            Main:\n            0x1d0000dc: mov %r14, %rdi\n            0x1d0000df: callq  0x1b277a40\n\n        (91) Jmp t63:Int -> B32\n            Main:\n            0x1d0000e4: jmp 0x1d000058\n\n      no fallthrough\n\n     B31: [profCount=8] (preds B14)\n        --- bc main(id 1078456160)36, fp 5, fixupFP 5, spOff 0,  [profTrans=2]\n        IterInit <BaseConst> 0 NK V:0 L:1 76 (112)\n        (200) t65:Int = LdPtrIterVal<InitCell> vec(0x80010180)=Vanilla, t12:PtrToElem\n            Main:\n            0x1d000054: movq  (%r13), %rbx\n\n        --- bc __invoke(id 1078456080)0e, fp 29, fixupFP 5, spOff 0,  [profTrans=4]\n        FuncEntry\n        (96) Jmp t65:Int -> B32\n\n      no fallthrough\n\n     B32: [profCount=8] (preds B31 B33)\n        --- bc __invoke(id 1078456080)11, fp 29, fixupFP 5, spOff 2,  [profTrans=4]\n        Add\n              t64:Int = phi t65:Int@B31, t63:Int@B33\n        (199) t64:Int = DefLabel\n        (101) t34:Int = AddInt t64:Int, 100\n            Main:\n            0x1d000058: add $0x64, %rbx\n```\n\nFull TC print: https://www.internalfb.com/phabricator/paste/view/P1437071588\n\nReviewed By: jano, voorka\n\nDifferential Revision: D58202121\n\nfbshipit-source-id: 59e0ab0f04be659bce1fb7fe23cc6e074c1af87f","shortMessageHtmlLink":"Add a test case to reproduce inefficient usage of DecReleaseCheck"}},{"before":"b30a4736660d474237e92b8438bde742abe1f7b5","after":"a007e3210c3a45bcd8f5d25906afc82225717c19","ref":"refs/heads/master","pushedAt":"2024-07-03T00:12:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix exception attribution for ServiceInterceptor\n\nSummary:\nThe current implementation uses the index of the  exception in the list of collected exceptions to find the `ServiceInterceptor` to blame.\n\nThis is completely wrong! If any of the interceptors in the list do not throw, then the index will be off, and the attribution will be incorrect. See unit tests.\n\nReviewed By: iahs\n\nDifferential Revision: D59294966\n\nfbshipit-source-id: 7345d513f0490ce16408cdd280cebc1e5e5cfc88","shortMessageHtmlLink":"Fix exception attribution for ServiceInterceptor"}},{"before":"1f9e63ecaeaafa65e50c45557e07dc6db9a95a95","after":"b30a4736660d474237e92b8438bde742abe1f7b5","ref":"refs/heads/master","pushedAt":"2024-07-02T22:11:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Build mvfst interop image using gcc/g++ 10\n\nSummary:\nFolly now requires gcc-10.\n\nThe interop image is using Ubuntu 20.04 which defaults to gcc-9 but has gcc-10 in the repos.\n\nReviewed By: lnicco\n\nDifferential Revision: D59295229\n\nfbshipit-source-id: d5fdcd25ecdfdca3b83903ce2ad4c8a96f1b42af","shortMessageHtmlLink":"Build mvfst interop image using gcc/g++ 10"}},{"before":"cd268e922d689f54781011d3ef6a8fd4622c38d9","after":"1f9e63ecaeaafa65e50c45557e07dc6db9a95a95","ref":"refs/heads/master","pushedAt":"2024-07-02T21:44:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove @patch.GeneratePatch annotation in tests and glean\n\nSummary: We will stop supporting `patch.GeneratePatch` in the following stacked diffs.\n\nReviewed By: thedavekwon, pranavtbhat\n\nDifferential Revision: D59285271\n\nfbshipit-source-id: 4953e0e32193ae9b2833b25c0878bf51fa87f2b6","shortMessageHtmlLink":"Remove @patch.GeneratePatch annotation in tests and glean"}},{"before":"0e93a4043892256ab47921f82998b4d043a1ad45","after":"cd268e922d689f54781011d3ef6a8fd4622c38d9","ref":"refs/heads/master","pushedAt":"2024-07-02T20:36:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Include program checksum in hash calculations\n\nSummary:\nTo catch the merging of schemas from different snapshots before they\nresult in data corruption, we include the checksum of the program contents in\nthe hash calculation for that program and all of its definitions.\nThis ensures the hashes are still stable across runs within a snapshot, but\nwill cause resolution to fail if multiple snapshots are combined.\n\nReviewed By: praihan\n\nDifferential Revision: D59247590\n\nfbshipit-source-id: a0971c9c86faf108f31c880094b7113f412f678c","shortMessageHtmlLink":"Include program checksum in hash calculations"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEdyPu8wA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/hhvm"}