From edf45fc40fd4cb52a595c49ed5834388563b407e Mon Sep 17 00:00:00 2001 From: Alex Hornby Date: Mon, 25 Nov 2024 09:59:30 -0800 Subject: [PATCH] fix hangs in watchman oss ubuntu tests by excluding liblzma-dev Summary: X-link: https://github.com/facebookincubator/zstrong/pull/1072 watchman oss tests on ubuntu are [hanging 2 hours on github and then failing](https://github.com/facebook/watchman/actions/runs/11989130985/job/33425158244), and locally show errors. One clue was that tests worked locally on centos stream 9 and fedora 40, pointing to one or more of the ubuntu system packages being the trigger. Turns out that having the ubuntu xz aka liblzma-dev system packages linked is triggering the issue on both ubuntu 22.04 and 24.04. Disabled system packages for xz and for glog and libunwind that also bring in the xz system packages on ubuntu. Why ubuntu's liblzma triggers this problem is unknown at this time. This change seems to be an improvement in that we get test results, with two tests showing intermittent failutes on ubuntu-22.04 runs. Reviewed By: ckwalsh Differential Revision: D66446570 fbshipit-source-id: 8a631e51012c7b90e867268451fd023304039589 --- build/fbcode_builder/manifests/glog | 3 ++- build/fbcode_builder/manifests/libunwind | 3 ++- build/fbcode_builder/manifests/xz | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/build/fbcode_builder/manifests/glog b/build/fbcode_builder/manifests/glog index b5d5fa814c..2649eaad18 100644 --- a/build/fbcode_builder/manifests/glog +++ b/build/fbcode_builder/manifests/glog @@ -24,7 +24,8 @@ HAVE_TR1_UNORDERED_SET=OFF [homebrew] glog -[debs] +# on ubuntu glog brings in liblzma-dev, which in turn breaks watchman tests +[debs.not(distro=ubuntu)] libgoogle-glog-dev [rpms.distro=fedora] diff --git a/build/fbcode_builder/manifests/libunwind b/build/fbcode_builder/manifests/libunwind index 0a4f03bc8f..fda19209ad 100644 --- a/build/fbcode_builder/manifests/libunwind +++ b/build/fbcode_builder/manifests/libunwind @@ -5,7 +5,8 @@ name = libunwind libunwind-devel libunwind -[debs] +# on ubuntu this brings in liblzma-dev, which in turn breaks watchman tests +[debs.not(distro=ubuntu)] libunwind-dev [download] diff --git a/build/fbcode_builder/manifests/xz b/build/fbcode_builder/manifests/xz index 0b27ad63cc..e6c0808ff0 100644 --- a/build/fbcode_builder/manifests/xz +++ b/build/fbcode_builder/manifests/xz @@ -1,7 +1,8 @@ [manifest] name = xz -[debs] +# ubuntu's package causes watchman's tests to hang +[debs.not(distro=ubuntu)] liblzma-dev [homebrew]