Skip to content

Commit 230474b

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Remove name and metadata from root package.json
Summary: Following D86869721, this removes the unused `name`, `version`, and `license` fields from the project level `package.json` (previously named `react-native/monorepo`). **Motivation** - **Simplicity**: Our root package.json is a Yarn project manifest, not a package, with the `version` field serving no functional purpose. `react-native/monorepo` was never published to npm, and so `name`, `version`, and `license` were never read. - **Correctness**: Since D86869721 and our recent work to formalise monorepo dependencies in `private/`, the workspace root no longer needs to be referenced by any part of our containing fbsource codebase — and this is a conceptual footgun (Yarn-installing a package that is itself a workspace). `react-native/monorepo` no longer needs to be named, addressable, or installable. Or, phrased another way: - Delete `name` — never try to reference this as an npm package! - Delete `version` — never think about versioning this file! - Delete `license` — unread, duplicate of `LICENSE.md`. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D86869720
1 parent 407a9ef commit 230474b

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
2-
"name": "@react-native/monorepo",
32
"private": true,
4-
"version": "1000.0.0",
5-
"license": "MIT",
63
"packageManager": "[email protected]",
74
"scripts": {
85
"android": "yarn --cwd packages/rn-tester android",

scripts/releases/set-version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ async function setVersion(
8989
...Object.values(packages),
9090
];
9191

92-
// Update all workspace packages
92+
// Update dependency versions in workspace packages
9393
await Promise.all(
9494
packagesToUpdate.map(pkg => updatePackageJson(pkg, newPackageVersions)),
9595
);

0 commit comments

Comments
 (0)