-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - borderStyle: 'dashed' and 'dotted' no longer works in combination with overflow: hidden in 0.76 #48078
Labels
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Platform: iOS
iOS applications.
Comments
cortinico
added
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
and removed
Needs: Triage 🔍
Flow
labels
Dec 4, 2024
FYI @joevilches (this change may not be related to any of the recent refactoring, since this is going from old arch to new arch). |
@NickGerleman thanks for the callout, I'll take a look regardless! |
Seems similar to #48392 |
joevilches
added a commit
to joevilches/react-native
that referenced
this issue
Dec 30, 2024
Summary: Was looking into facebook#48078 which was brought to my attention due to my recent refactorings of iOS Views, especially around how overflow: hidden works. This bug was not brought on by my changes but seems to be a lingering Fabric bug (iirc this bool was not changed when I refactored things) Anyway, dotted/dashed borders did not work with overflow: hidden. The reason why is we use core animation borders in this case which is incorrect as CA cannot do these types of borders. So I added a check to make sure that the borders are solid as well if we want to use CA to draw them. Differential Revision: D67720492
Should be fixed in #48414 for new arch which I think you are using? The logs say otherwise but not sure how accurate that is |
joevilches
added a commit
to joevilches/react-native
that referenced
this issue
Dec 30, 2024
…facebook#48414) Summary: Was looking into facebook#48078 which was brought to my attention due to my recent refactorings of iOS Views, especially around how overflow: hidden works. This bug was not brought on by my changes but seems to be a lingering Fabric bug (iirc this bool was not changed when I refactored things) Anyway, dotted/dashed borders did not work with overflow: hidden. The reason why is we use core animation borders in this case which is incorrect as CA cannot do these types of borders. So I added a check to make sure that the borders are solid as well if we want to use CA to draw them. Changelog: [iOS] [Fixed] - Dashed & dotted borders now work with overflow: hidden Reviewed By: mdvacca Differential Revision: D67720492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Platform: iOS
iOS applications.
Description
After upgrading to expo 52 and react-native 0.76.3 I noticed some of my dashed borders had disappeared in some cases on iOS. On further investigation, I discovered that dashed borders no longer work when borderStyle: "dashed" | "dotted" are used in combination with overflow: "hidden" or overflow: "scroll". Instead of a dashed or dotted border, it shows a solid border.
Dotted and dashed borders work correctly with overflow: "visible"
Dotted and dashed borders also work correctly in android.
I took a cursory look through the source code, but couldn't see the issue - that being said, if someone can point me in somewhat the right direction, I'd be happy to take a swing at a fix.
Steps to reproduce
React Native Version
0.76.3
Affected Platforms
Runtime - iOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/jorjordandan/borderIssue
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: