Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): centralize JS engine dependency configuration #49297

Closed
wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Feb 10, 2025

Summary:

Note

This PR is part of JavaScriptCore Extraction to this repository: https://github.com/react-native-community/javascriptcore

This PR centralizes the setup of js engine dependencies which need to be defined when building with dynamic frameworks. This will allow us to change linked framework if using a third party one in the future

Changelog:

[INTERNAL] [CHANGED] - centralize JS engine dependency configuration

Test Plan:

CI Green (Build needs to go properly)

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 10, 2025
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@okwasniewski
Copy link
Contributor Author

Looks like dynamic frameworks are failing, I'm looking into this

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! :D

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

Dynamic frameworks are still failing.

You can build them locally by using:

USE_FRAMEWORKS=dynamic bundle exec pod install

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@okwasniewski
Copy link
Contributor Author

After talking with @cipolleschi, I realized that removing those dependencies is impossible because there are build errors about undefined symbols when using dynamic frameworks. I'll create a centralized function that adds those dependencies so its easier to implement logic of linking a 3rd party engine.

@okwasniewski okwasniewski changed the title fix: remove unneeded dependencies on JS engines feat(iOS): centralize JS engine configuration Feb 11, 2025
@okwasniewski okwasniewski changed the title feat(iOS): centralize JS engine configuration feat(iOS): centralize JS engine dependency configuration Feb 11, 2025
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a nit

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in e7de582.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 11, 2025
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @okwasniewski in e7de582

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants