cipolleschi/0 77 properly handle null values tm interop #49298
+28
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Picking d423679 now that it's landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR targets
0.78-stableand it mimics this other PR onmain#49250The original PR has not landed in
mainyet, but we need it if we want to prepare a golden release candidate.The problem we are seeing is that some legacy module were passing null values from JS to Native and the null value was used in native to make business logic decisions.
In the New Architecture, null values passed down from JS to Native are stripped out and native does not receive them.
This break some Legacy Libraries that are not migrated to the New Architecture yet.
This change fixes this problem and properly forward null values to modules working throught the interop layer.
Changelog:
[iOS][Fixed] - Properly handle null value in TurboModule Interop layer.
Test Plan:
Tested in a reproducer provided by the community.
All internal tests on the mentioned PR on main are green.