-
Notifications
You must be signed in to change notification settings - Fork 25k
Closed
Labels
☂️ UmbrellaTo label issues that serve as coordination point and drivers for tasks in the react-native repoTo label issues that serve as coordination point and drivers for tasks in the react-native repoGood first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.
Description
☂️ Help us Kotlin-ify React Native - Round 3
Hey all 👋
After the successful second round, we're back with another round of tasks to help us improve Kotlin support in React Native core. In this stage we are looking for help to migrate a few more files to Kotlin.
How to work
If you wish to grab one of the tasks, you should:
- Verify that the task is not claimed yet.
- Comment here that you claim a task.
- Start working on the task. Testing instructions are below.
- Send the PR for review. Ping @mateoguzmana, @cortinico or @mdvacca for a review.
- You can’t claim more than one task at a time.
- If you’re not completing the task within a week, we’ll release it for the next contributor.
Code formatting
Please use KtFmt to format Kotlin classes.
You can use the web UI to reformat directly from the browser.
Migrating files to Kotlin
Please act as follow:
- Fork and clone the repo
- Verify that RN-Tester, our reference app, runs with yarn && yarn android from the root folder
- Migrate the file to Kotlin
- Verify that RN-Tester runs again using the same command.
Other important things to take into account:
- Avoid using Hungarian notation for the variables when the file is migrated. E.g.:
mMyAwesomePropertyshould becomemyAwesomeProperty - You might have to run the project in old architecture as well to ensure nothing breaks there when building. You can easily switch in the RN-Tester by setting
newArchEnabled=falsein packages/rn-tester/android/app/gradle.properties - Tap around in a few screens after migrating (helps to ensure nothing is breaking at runtime)
List of files to migrate
- react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java assigned to @nitinshukla413 Migrate FrescoBasedReactTextInlineImageShadowNode.java to Kotlin #50693
- react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java assigned to @gouravkhunger refactor: FrescoBasedTextInlineImageSpan #50532
- react/modules/blob/FileReaderModule.java assigned to @devanshsaini11 Migrate FileReaderModule to kotlin #50562
- react/modules/blob/BlobProvider.java assigned to @JatinDream11 refactor: migrate BlobProvider.java to Kotlin #50756
- react/runtime/ReactLifecycleStateManager.java assigned to @rohitverma-d11 Kotlinify ReactLifecycleStateManager #50685
- react/views/textinput/ReactEditTextInputConnectionWrapper.java assigned to @Q1w1N refactor: ReactEditTextInputConnectionWrapper implemented in kotlin #50573
- react/uimanager/ReactClippingViewGroupHelper.java assigned to @Priyanka26012 Migrate ReactClippingViewGroupHelper.java to Kotlin #50679
- react/uimanager/ReactStylesDiffMap.java assigned to @poonamjain96 Migrated file ReactStylesDiffMap to kotlin #50616
- react/bridge/UiThreadUtil.java assigned to @riteshshukla04 Migrate UiThreadUtil to Kotlin #50536
- react/bridge/DynamicFromObject.java assigned to @yasir6jan refactor: migrate DynamicFromObject to Kotlin #50754
- react/bridge/DynamicFromArray.java assigned to @BogiKay refactor: migrate DynamicFromArray to Kotlin #50602
- react/bridge/DynamicFromMap.java assigned to @artus9033 refactor: migrate DynamicFromMap to Kotlin #50597
- react/bridge/JavaScriptModuleRegistry.java assigned to @gustavoabel
- react/bridge/JSBundleLoader.java assigned to @yogeshpaliyal refactor: Rewrite JSBundleLoader from Java to Kotlin #50911
- react/bridge/Inspector.java assigned to @Vin-Xi refactor: rewrite Inspector from Java to Kotlin #50947
- react/uimanager/ViewGroupManager.java assigned to @riteshshukla04 Migrate ViewGroupManager to kotlin #50895
- react/bridge/BaseJavaModule.java assigned to @l2hyunwoo [kotlinify] Kotlinify BaseJavaModule #51207
- react/LazyReactPackage.java assigned to @Xintre refactor: migrated file LazyReactPackage to Kotlin #51085
- react/bridge/JavaModuleWrapper.java assigned to @DrRefactor refactor: Rewrite JavaModuleWrapper from Java to Kotlin #50882
cortinico, migueldaipre, shubhamguptadream11, szymonrybczak, mensonones and 11 more
Metadata
Metadata
Assignees
Labels
☂️ UmbrellaTo label issues that serve as coordination point and drivers for tasks in the react-native repoTo label issues that serve as coordination point and drivers for tasks in the react-native repoGood first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.