[kotlinify] Refacetor BaseJavaModule from java to kotlin #54504
+552
−569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
javache
requested changes
Nov 12, 2025
Member
javache
left a comment
javache
left a comment
There was a problem hiding this comment.
Let's try and limit changes to just BaseJavaModule. Having to change anything else means this is a breaking change.
| public @Nullable Map<String, Object> getConstants() { | ||
| return null; | ||
| } | ||
| public open val constants: Map<String, Any>? |
Member
There was a problem hiding this comment.
This is a breaking change, please revert this back to the function form.
Contributor
Ditto to this. I'd suggest we (someone from Meta) do this migration as it's going to be a painful one for the whole ecosystem |
l2hyunwoo
commented
Nov 13, 2025
| public @Nullable Map<String, Object> getConstants() { | ||
| return null; | ||
| } | ||
| public open fun getConstants(): Map<String, Any>? = null |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change, please revert this back to the function form.
I applied your review @javache
Contributor
Author
|
Also the other changes in this PR are fixes for errors that were reported by the linter and the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
BaseJavaModuleclass from Java to Kotlin.Changelog:
[ANDROID] [CHANGED] - Refactor BaseJavaModule from Java to Kotlin
Test Plan:
e2e-test-androidtask should run successfully