fix(a11y): android prevent redundant double screen reader focus step on <Text role="link">
#54515
+80
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
mdjastrzebski
force-pushed
the
fix/android-text-role-link
branch
from
9ebbe9b to
6cf213e
Compare
mdjastrzebski
force-pushed
the
fix/android-text-role-link
branch
from
6cf213e to
c59d118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #53240
Resolves an Android-only issue where a top-level
<Text role="link">Link Text</Text>would generate two accessibility (screen reader) focus steps:This behavior was inconsistent with iOS behavior, which generated a single screen reader step, resulting in a poor user experience due to unnecessary repetition of information.
This PR resolves the issue in a way that allows mixing plain text and links while still yielding additional focus steps for nested links if there is any other text present or if there are multiple links.
Android after
Android.Link.Text.Stops.-.After.mp4
Android before
Android.Link.Text.Stops.-.Before.mp4
iOS (for comparison)
iOS.Link.Text.Stops.mp4
Changelog:
Test Plan:
Open RN Tester on "Text with link role" example and test with screen reader.