Remove name and metadata from root package.json #54521
Closed
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…cebook#54519) Summary: **Background** `react-native/eslint` was relocated and renamed to `react-native/eslint-plugin-monorepo` in D76088698. **This diff** This updates all call sites to correctly address the `react-native/eslint-plugin-monorepo` package, enabling us to remove the monorepo itself from fbsource's `package.json#workspaces` (which was the only reason this kept working before). Changelog: [Internal] Differential Revision: D86869721
Summary: Following D86869721, this removes the unused `name`, `version`, and `license` fields from the project level `package.json` (previously named `react-native/monorepo`). **Motivation** - **Simplicity**: Our root package.json is a Yarn project manifest, not a package, with the `version` field serving no functional purpose. `react-native/monorepo` was never published to npm, and so `name`, `version`, and `license` were never read. - **Correctness**: Since D86869721 and our recent work to formalise monorepo dependencies in `private/`, the workspace root no longer needs to be referenced by any part of our containing fbsource codebase — and this is a conceptual footgun (Yarn-installing a package that is itself a workspace). `react-native/monorepo` no longer needs to be named, addressable, or installable. Or, phrased another way: - Delete `name` — never try to reference this as an npm package! - Delete `version` — never think about versioning this file! - Delete `license` — unread, duplicate of `LICENSE.md`. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D86869720
huntie
force-pushed
the
export-D86869720
branch
from
230474b to
27bbd73
Compare
|
This pull request has been merged in 5df92e1. |
Contributor
|
This pull request has been reverted by aab370b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following D86869721, this removes the unused
name,version, andlicensefields from the project levelpackage.json(previously namedreact-native/monorepo).Motivation
versionfield serving no functional purpose.react-native/monorepowas never published to npm, and soname,version, andlicensewere never read.private/, the workspace root no longer needs to be referenced by any part of our containing fbsource codebase — and this is a conceptual footgun (Yarn-installing a package that is itself a workspace).react-native/monorepono longer needs to be named, addressable, or installable.Or, phrased another way:
name— never try to reference this as an npm package!version— never think about versioning this file!license— unread, duplicate ofLICENSE.md.Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D86869720