Expose jsitooling via prefab #54529
Closed
Expose jsitooling via prefab #54529
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Nightlies for reanimated and worklets started failing after D86200983 That's because the header `JSRuntimeBindings.h` is now exposed via `jsitooling` but such target is not accessible via prefab for libreactnative.so. This adds back the header and should solve the breakages. Changelog: [Internal] [Changed] - Differential Revision: D86958415
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86958415. |
|
This pull request has been merged in f8e8c4e. |
Collaborator
|
This pull request was successfully merged by @cortinico in f8e8c4e When will my fix make it into a release? | How to file a pick request? |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Nightlies for reanimated and worklets started failing after D86200983
That's because the header
JSRuntimeBindings.his now exposed viajsitoolingbut such target is not accessible via prefab for libreactnative.so.This adds back the header and should solve the breakages.
Changelog:
[Internal] [Changed] -
Differential Revision: D86958415