From 83570d36f7ca318a298ef65bd3275feaa247bc1c Mon Sep 17 00:00:00 2001 From: akankshamahajan Date: Thu, 14 Dec 2023 10:55:52 -0800 Subject: [PATCH] Fix Stall start_time Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: --- db/db_impl/db_impl_write.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/db/db_impl/db_impl_write.cc b/db/db_impl/db_impl_write.cc index 8add1e990b74..91e1c582d6ce 100644 --- a/db/db_impl/db_impl_write.cc +++ b/db/db_impl/db_impl_write.cc @@ -1825,7 +1825,6 @@ uint64_t DBImpl::GetMaxTotalWalSize() const { Status DBImpl::DelayWrite(uint64_t num_bytes, WriteThread& write_thread, const WriteOptions& write_options) { mutex_.AssertHeld(); - uint64_t start_time = 0; bool delayed = false; { // To avoid parallel timed delays (bad throttling), only support them @@ -1839,11 +1838,12 @@ Status DBImpl::DelayWrite(uint64_t num_bytes, WriteThread& write_thread, delay = 0; } TEST_SYNC_POINT("DBImpl::DelayWrite:Start"); + uint64_t start_time = immutable_db_options_.clock->NowMicros(); + if (delay > 0) { if (write_options.no_slowdown) { return Status::Incomplete("Write stall"); } - start_time = immutable_db_options_.clock->NowMicros(); TEST_SYNC_POINT("DBImpl::DelayWrite:Sleep"); // Notify write_thread about the stall so it can setup a barrier and