Try to deflake unit test RoundRobinSubcompactionsAgainstPressureToken
#13254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbi42
force-pushed
the
roundrobin-flaky
branch
from
e3d646f to
0963206
Compare
hx235
reviewed
Dec 30, 2024
| @@ -6446,21 +6446,34 @@ TEST_P(RoundRobinSubcompactionsAgainstPressureToken, PressureTokenTest) { | |||
| ASSERT_EQ(kFilesPerLevel, NumTableFilesAtLevel(lvl, 0)); | |||
| } | |||
|
|
|||
| bool compaction_num_verified = false; | |||
There was a problem hiding this comment.
nit: compaction_num_input_files_verified
hx235
reviewed
Dec 30, 2024
| // Pick a small target level size to pick more files to compact | ||
| // and trigger subcompaction. | ||
| // Cannot be too small to cause compaction pressure. | ||
| options.max_bytes_for_level_base = 40 * kKeysPerBuffer * 1024; |
There was a problem hiding this comment.
Can you translate 40 to something related to kFilesPerLevel and kNumSubcompactions just so to avoid hard-coded value?? Maybe kFilesPerLevel - 4* kNumSubcompactions? Also add comment about (1) the actual num subcompaction won't be 4 since it will be constrained by bg compaction number env_->SetBackgroundThreads(kNumSubcompactions, Env::LOW); (2) how compaction pressure relates to max_bytes_for_level_base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: unit test
RoundRobinSubcompactionsAgainstPressureToken.PressureTokenTesthas been flaky. num_planned_subcompactions can be 1 for two reasons: compactions not having enough input files or that there were not enough bg threads. This PR updates the test to try to trigger a larger compaction for subcompactions, and added a callback to verify compactions have enough input files.Test plan: monitor future failure.