From 1518f434efb694fadbdd381913953b5f9e70b89b Mon Sep 17 00:00:00 2001 From: Xiaowei Lu Date: Fri, 24 Jan 2025 12:33:30 -0800 Subject: [PATCH] Add detector for network environment Summary: ## Context It's helpful to collect information about the networking environment when edenfs is not working properly. ## This Diff Added a hook for `eden rage` to check networking environment. It should be implemented based on specific requirements. Reviewed By: jdelliot Differential Revision: D68598730 fbshipit-source-id: dc1b1748a6b03f8b66d981525abaffe0b7ffdbd1 --- eden/fs/cli/rage.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/eden/fs/cli/rage.py b/eden/fs/cli/rage.py index 6198781b16d75..dbb82f2f93fb0 100644 --- a/eden/fs/cli/rage.py +++ b/eden/fs/cli/rage.py @@ -40,6 +40,7 @@ from .facebook.rage import ( find_fb_cdb, get_host_dashboard_url, + get_networking_environment, get_quickstack_cmd, setup_fb_env, ) @@ -62,6 +63,9 @@ def get_quickstack_cmd( ) -> Optional[List[str]]: return None + def get_networking_environment() -> Optional[str]: + return None + try: from eden.fs.cli.doctor.facebook.check_vscode_extensions import ( @@ -179,11 +183,16 @@ def print_diagnostic_info( section_title("System info:", out) user = getpass.getuser() host = hostname_mod.get_normalized_hostname() + net_env = get_networking_environment() header = ( f"User : {user}\n" f"Hostname : {host}\n" f"Version : {version_mod.get_current_version()}\n" ) + + if net_env: + header += f"Network : {net_env}\n" + out.write(header) if sys.platform != "win32": # We attempt to report the RPM version on Linux as well as Mac, since Mac OS