Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Compatibility with Pymakr #323

Open
RalphHogenbirk opened this issue Nov 7, 2018 · 0 comments
Open

Compatibility with Pymakr #323

RalphHogenbirk opened this issue Nov 7, 2018 · 0 comments

Comments

@RalphHogenbirk
Copy link

I'm working on the Pymakr package and I'm struggling with some compatibility issues with the atom-ide-ui package. Whenever the latter is activated, the Pymakr overlay resizes to the smallest size and can't be resized back up. Related issue is here: sg-wireless/pymakr-atom#92. Some screenshots:

How it should look:
screen shot 2018-11-07 at 18 13 45

How it looks with atom-ide-ui activated:
screen shot 2018-11-07 at 18 13 02

Now, I've been checking and changing the Pymakr code to prevent any possible CSS conflicts, and I've narrowed it down to this point:

The html style property of the div with class 'pymakr' seems to be set to height: 35px after activating the atom-ide-ui plugin (<div class="pymakr pymakr-open" style="height: 35px;">) and can't seem to be changed back from the Pymakr code. This height is being set correctly when dragging the overlay up by the resize bar (from this line: https://github.com/pycom/pymakr-atom/blob/master/lib/main/terminal.js#L77). But even though it's setting the correct height to the correct div, but the element inspector shows it staying at 35px no matter what.

I know it might be an issue on the Pymakr plugin and not atom-ide-ui. But If anyone from the dev team with a little bit of time to look in to this and give me some advise, so I can possibly adjust the Pymakr package to work around the issue, that would be of great help to me!

Versions

  • Atom: 1.32.0
  • Client OS: OSX
  • atom-ide-ui: 0.13.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant