Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple tickets of returning ARRAY in Gravity Forms Confirmations #2

Open
jimtrue opened this issue Sep 18, 2019 · 1 comment
Open

Multiple tickets of returning ARRAY in Gravity Forms Confirmations #2

jimtrue opened this issue Sep 18, 2019 · 1 comment

Comments

@jimtrue
Copy link

jimtrue commented Sep 18, 2019

Reporting multiple support tickets of Clients using Facebook Pixel for WordPress and Confirmations returning ARRAY instead of the actual Confirmation from Gravity Forms. We have narrowed this down to an issue with the Return Value with Facebook Pixel.

One of our developer's is filing a PR against this issue.
@travislopes travislopes mentioned this issue Sep 19, 2019
Closed
@karlpotter
Copy link

karlpotter commented Oct 16, 2019 •
edited
Loading

Since the opening of PR #3 there have been 13 tickets in our support queue that could have been resolved by merging this PR. The total number of tickets related to this issue in our system is approaching at least 50 within the last 5 months.

Please consider reviewing and merging PR #3.

facebook-github-bot pushed a commit that referenced this issue Nov 27, 2019
@travislopes @facebook-github-bot
Fix pixel not appending properly with Gravity Forms redirect confirma…
628ebf2 
…tions (#3)

Summary:
### Description
This PR fixes an issue where Gravity Forms confirmations do not process properly when the Facebook Pixel is added to a redirect type confirmation.

When a redirect type confirmation is used, the confirmation is updated to return the Facebook Pixel along with a Javascript based redirect rather than using Gravity Forms' header based redirect.

(Related Issue: #2)

### Testing Instructions
1. Create a Gravity Forms form.
1. Set the default confirmation to the Text type.
1. Submit the form.
1. Confirm the Facebook Pixel is properly included and event was registered.
1. Change the default confirmation to the Page type.
1. Submit the form.
1. Confirm the Facebook Pixel is properly included, the event was registered and user was redirected to selected page.
1. Change the default confirmation to the Redirect type.
1. Submit the form.
1. Confirm the Facebook Pixel is properly included, the event was registered and user was redirected to the defined redirect URL.
Pull Request resolved: #3

Differential Revision: D18713432

Pulled By: vinothsa

fbshipit-source-id: b869218d5454b5d26915edc012f3ce4c1afbdff1
facebook-github-bot pushed a commit that referenced this issue May 22, 2023
@facebook-github-bot
Fix PHP null exception.
d155011 
Summary:
Issue reported on the Wordpress forum.

https://wordpress.org/support/topic/php-fatal-error-364/

PHP Fatal error: Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in /srv/htdocs/wp-content/plugins/official-facebook-pixel/core/FacebookWordpressOpenBridge.php:119

Reviewed By: vahidkay-meta

Differential Revision: D46067579

fbshipit-source-id: 2fc19965631ed01042b58af931d6b975f7c19ce6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlpotter @jimtrue