From ef2f2cf55ed2183a36e33d5ade33c173570e4786 Mon Sep 17 00:00:00 2001 From: Jialiang Tan Date: Thu, 5 Dec 2024 21:54:32 -0800 Subject: [PATCH] feat: Add priority based memory reclaim framework (#111) Summary: Pull Request resolved: https://github.com/facebookincubator/nimble/pull/111 * Adds priority base reclaiming to memory reclaim framework. The priority determines which memory pool to reclaim first on the same level. This would help to make reclaim more application logic aware. * Make join node reclaim priority lower than others. This is because cost of reclaiming (spilling) on join node is high compared to other nodes. X-link: https://github.com/facebookincubator/velox/pull/11598 Reviewed By: xiaoxmeng Differential Revision: D66261340 Pulled By: tanjialiang fbshipit-source-id: c03b2ef25b39dc8771f66321731d5a88da26638e --- dwio/nimble/velox/tests/VeloxWriterTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwio/nimble/velox/tests/VeloxWriterTests.cpp b/dwio/nimble/velox/tests/VeloxWriterTests.cpp index bc54fa0..c8b41f0 100644 --- a/dwio/nimble/velox/tests/VeloxWriterTests.cpp +++ b/dwio/nimble/velox/tests/VeloxWriterTests.cpp @@ -293,7 +293,7 @@ TEST_P(RawStripeSizeFlushPolicyTest, RawStripeSizeFlushPolicy) { namespace { class MockReclaimer : public velox::memory::MemoryReclaimer { public: - explicit MockReclaimer() {} + explicit MockReclaimer() : velox::memory::MemoryReclaimer(0) {} void setEnterArbitrationFunc(std::function&& func) { enterArbitrationFunc_ = func; }