Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash oomd on startup if --cgroup-fs path is not cgroup2 #62

Open
danobi opened this issue Apr 19, 2019 · 3 comments
Open

Crash oomd on startup if --cgroup-fs path is not cgroup2 #62

danobi opened this issue Apr 19, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@danobi
Copy link
Contributor

danobi commented Apr 19, 2019

Letting oomd be silently run against a cgroup1 hierarchy could lead to subtle issues down the line.

@danobi danobi added the enhancement New feature or request label Apr 19, 2019
@danobi
Copy link
Contributor Author

danobi commented Apr 19, 2019

Reported in #61

@hakavlad
Copy link

@danobi

You can find actual cgroup2 root location in /proc/mounts:

$ cat /proc/mounts | grep cgroup2
cgroup /sys/fs/cgroup/unified cgroup2 rw,nosuid,nodev,noexec,relatime,nsdelegate 0 0

Perhaps it is worth taking the default cgroup2 root from /proc/mounts instead of using /sys/fs/cgroup by default.

@danobi
Copy link
Contributor Author

danobi commented Apr 22, 2019

Perhaps it is worth taking the default cgroup2 root from /proc/mounts instead of using /sys/fs/cgroup by default.

Oh yeah I like this idea. I'll file a separate issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants